Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041711Openbravo ERP09. Financial managementpublic2019-08-28 13:332019-09-04 16:37
ReporterSandrahuguet 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041711: Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params
DescriptionSubquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params

final String existsSubQuery = "( select 1 "
+ " from " + tablename + " dt "
+ " where f.record_id = dt." + tablename + "_id"
+ " and dt.documentno = '" + documentNo + "' )";
Steps To ReproduceTest Plan
Go to Journal Entries Report and set:
    Organization: Region Norte
    General Ledger: F&B España
    From: 01-07-2018
    To: 24-07-2019
    From Account: (43000) Clientes (euros) a corto plazo
    To Account: (47700) Hacienda Pública IVA repercutido
    Document: AR Invoice
    DocumentNo: 1000259
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
related to defect 00412523.0PR19Q4 closed collazoandy4 ReportGeneralLedgerJournal.getDocuments is not using bind-params 
depends on backport 00417123.0PR19Q3.1 closed Triage Omni OMS Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params 
depends on backport 00417133.0PR19Q2.3 closed Triage Omni OMS Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-28 13:33SandrahuguetNew Issue
2019-08-28 13:33SandrahuguetAssigned To => platform
2019-08-28 13:33SandrahuguetModules => Core
2019-08-28 13:33SandrahuguetTriggers an Emergency Pack => No
2019-08-28 13:33SandrahuguetAssigned Toplatform => Triage Finance
2019-08-28 13:34SandrahuguetCategoryC. Security => 09. Financial management
2019-08-28 13:35SandrahuguetSummarySubquery in getDocumentNo is not using bind-params => Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params
2019-08-28 13:35SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=19345#r19345
2019-08-28 13:35SandrahuguetRelationship addedrelated to 0038136
2019-08-28 13:36SandrahuguetRelationship addedrelated to 0041452
2019-08-28 13:38SandrahuguetReproducibilityhave not tried => always
2019-08-28 13:40SandrahuguetStatusnew => scheduled
2019-08-28 14:01SandrahuguetRelationship addedrelated to 0041252
2019-08-28 14:01SandrahuguetRelationship deletedrelated to 0041452
2019-08-30 15:05SandrahuguetAssigned ToTriage Finance => collazoandy4
2019-09-02 01:06collazoandy4Note Added: 0114353
2019-09-04 11:06hgbotCheckin
2019-09-04 11:06hgbotNote Added: 0114391
2019-09-04 11:06hgbotStatusscheduled => resolved
2019-09-04 11:06hgbotResolutionopen => fixed
2019-09-04 11:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/dbb465c9f73a02b44b158f61dfcbcc5a2d0ebb6a [^]
2019-09-04 11:08SandrahuguetReview Assigned To => Sandrahuguet
2019-09-04 11:08SandrahuguetNote Added: 0114394
2019-09-04 11:08SandrahuguetStatusresolved => closed
2019-09-04 11:08SandrahuguetFixed in Version => 3.0PR19Q4
2019-09-04 16:37hudsonbotCheckin
2019-09-04 16:37hudsonbotNote Added: 0114403

Notes
(0114353)
collazoandy4   
2019-09-02 01:06   
Test Plan
  Go to Journal Entries Report and filter by
    Document: AR Invoice
    Document No: 1000259
    Click on Search button and check that only one entry for 12-07-2018 is shown
  Go to Sales Invoice and create a new record:
    Business Partner: Alimentos y Supermercados, S.A
    Document No: 1000259
    Create a new record in Lines tab:
      Product: Agua sin Gas 1L
      Invoiced Quantity: 10
    Complete and Post the invoice
  Go to Journal Entries Report and filter by
    Document: AR Invoice
    Document No: 1000259
    Click on Search button and check that two entries are shown, one for 12-07-2018 and another for today
(0114391)
hgbot   
2019-09-04 11:06   
Repository: erp/devel/pi
Changeset: dbb465c9f73a02b44b158f61dfcbcc5a2d0ebb6a
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Sun Sep 01 16:47:46 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/dbb465c9f73a02b44b158f61dfcbcc5a2d0ebb6a [^]

Fixes issue 41711: Subquery in getDocumentNo in ReportGeneralLedgerJournal is
not using bind-params

Added the missing bind-params
Now all documents id with the same documentNo is used to filter the accounting records

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal_data.xsql
---
(0114394)
Sandrahuguet   
2019-09-04 11:08   
code review + testing ok
(0114403)
hudsonbot   
2019-09-04 16:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2e882fde1e88 [^]
Maturity status: Test