Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041694Openbravo ERP04. Warehouse managementpublic2019-08-26 14:142020-01-20 14:07
Reporterngarcia 
Assigned ToTriage Omni WMS 
PriorityurgentSeveritymajorReproducibilityalways
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041694: Wrong accounting entry for Cost Adjustments over production products with transactions in more than one legal organization
DescriptionWrong accounting entry for Cost Adjustments over production products with transactions in more than one legal organization
Steps To ReproduceAs group admin role:
   In Organization window, remove the General Ledger from 'F&B International Group' organization
   Assign 'F&B International Group US/A/US Dollar' general ledger to 'F&B US, Inc.' organization
   Create a new product in * organization
   Set it as production
   Create a Goods Receipt in F&B España Region Norte
   Create another Goods Receipt in F&B US, East Coast
   Add a purchase price list in the price lists of the two business partner included
   Create a Goods Shipment in F&B US, East Coast
   Launch the costing background process and check the costing entries are created at * level (as it is a production product)
   Add a manual cost adjustment to the transaction related to the goods receipt done in España Region Norte
   Post it
   BEFORE THE FIX: Check there are accounting entries created for F&B US East Cost and F&B España, S.A. US/A/Euro general ledger
   AFTER THE FIX: Check there are some cost adjustment lines with Need Posting = 'Y' that belong to F&B US that did not generate any accounting entry
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0024530 new Triage Omni WMS The Cost of the Manufacturing products should be calculated with the new costing engine. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-26 14:14ngarciaNew Issue
2019-08-26 14:14ngarciaAssigned To => Triage Finance
2019-08-26 14:14ngarciaModules => Core
2019-08-26 14:14ngarciaResolution time => 1568584800
2019-08-26 14:14ngarciaTriggers an Emergency Pack => No
2019-08-26 14:14ngarciaIssue Monitored: networkb
2019-08-27 14:56aferrazAssigned ToTriage Finance => collazoandy4
2019-08-27 20:05collazoandy4Statusnew => scheduled
2019-08-27 21:26collazoandy4Note Added: 0114285
2019-08-29 13:15hgbotCheckin
2019-08-29 13:15hgbotNote Added: 0114326
2019-08-29 13:15hgbotStatusscheduled => resolved
2019-08-29 13:15hgbotResolutionopen => fixed
2019-08-29 13:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bf50dc6daf1aab806e09d74cdd1ee944d2fae99f [^]
2019-08-29 13:17SandrahuguetReview Assigned To => Sandrahuguet
2019-08-29 13:17SandrahuguetNote Added: 0114327
2019-08-29 13:17SandrahuguetStatusresolved => closed
2019-08-29 13:17SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-30 20:01hudsonbotCheckin
2019-08-30 20:01hudsonbotNote Added: 0114346
2019-09-09 13:43ngarciaAssigned Tocollazoandy4 => Triage Finance
2019-09-09 13:43ngarciaNote Added: 0114458
2019-09-09 13:43ngarciaStatusclosed => new
2019-09-09 13:43ngarciaResolutionfixed => open
2019-09-09 13:43ngarciaFixed in Version3.0PR19Q4 =>
2019-09-09 13:44ngarciaNote Edited: 0114458bug_revision_view_page.php?bugnote_id=0114458#r19360
2019-09-09 13:47ngarciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19362#r19362
2019-09-09 13:57SandrahuguetAssigned ToTriage Finance => collazoandy4
2019-09-09 22:40collazoandy4Statusnew => scheduled
2019-09-10 16:50collazoandy4Note Added: 0114505
2019-09-10 16:50collazoandy4Note Edited: 0114285bug_revision_view_page.php?bugnote_id=0114285#r19372
2019-09-16 14:02ngarciaRelationship addedcaused by 0024530
2019-09-18 08:36hgbotCheckin
2019-09-18 08:36hgbotNote Added: 0114611
2019-09-18 15:36hudsonbotCheckin
2019-09-18 15:36hudsonbotNote Added: 0114644
2019-09-23 11:12SandrahuguetTypedefect => design defect
2019-09-23 11:16SandrahuguetNote Added: 0114718
2019-09-23 11:33SandrahuguetAssigned Tocollazoandy4 => Triage Finance
2019-09-23 11:33SandrahuguetStatusscheduled => acknowledged
2020-01-20 14:07ngarciaResolution time1568584800 =>

Notes
(0114285)
collazoandy4   
2019-08-27 21:26   
(edited on: 2019-09-10 16:50)
Test Plan
  As group admin role:
   Create a new production product (Costing) in * organization
     Set a standard cost of 5
   Create a Goods Receipt in F&B España Region Norte for Costing product with 5 units
   Create another Goods Receipt in F&B US, East Coast for Costing product with 10 units
   Create a Goods Shipment in F&B US, East Coast for 10 units of Costing product
   Launch the costing background process and check the product transactions have cost calculated
   Add a manual cost adjustment to the transaction related to the goods receipt done in España Region Norte
   Go to the new cost adjustment created and Post it and check
     Accounting entries for F&B US East Cost organizations are only for F&B International Group US/A/US Dollar General Ledger
     Accounting entries for F&B España - Región Norte are for both general ledgers (F&B España, S.A. US/A/Euro and F&B International Group US/A/US Dollar)
Test Plan II
  As group admin role
    Create a new production product (Costing2) in * organization
     Set a standard cost of 5
   Create a Goods Receipt in F&B España Region Norte for Costing2 product with 5 units
   Create a Goods Shipment in F&B España Region Norte for 5 units of Costing2 product
   Launch the costing background process and check the product transactions have cost calculated
   Add a manual cost adjustment to the transaction related to the goods receipt
   Go to the new cost adjustment created and Post it and check
     Accounting entries for F&B España - Región Norte are for both general ledgers (F&B España, S.A. US/A/Euro and F&B International Group US/A/US Dollar)
Test Plan III
  As group admin role
    Create a new production product (Costing3) in * organization
     Set a standard cost of 5
   Create a Goods Receipt in F&B US, East Coast for Costing3 product with 5 units
   Create a Goods Shipment in F&B US, East Coast for 5 units of Costing3 product
   Launch the costing background process and check the product transactions have cost calculated
   Add a manual cost adjustment to the transaction related to the goods receipt
   Go to the new cost adjustment created and Post it and check
     Accounting entries for F&B US East Cost organizations are only for F&B International Group US/A/US Dollar General Ledger
(0114326)
hgbot   
2019-08-29 13:15   
Repository: erp/devel/pi
Changeset: bf50dc6daf1aab806e09d74cdd1ee944d2fae99f
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Aug 27 15:02:18 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/bf50dc6daf1aab806e09d74cdd1ee944d2fae99f [^]

Fixes issue 41694: Wrong accounting entry for Cost Adjustments over production
products with transactions in more than one legal organization

When a Cost adjustment have lines from with organizations that doesn't belongs to
the same natural tree a wrong accounting schema was used to create the fact lines.

Now the accounting schema used to create the fact lines are checked if it's belongs
to the same natural tree than the transaction line.

---
M src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java
---
(0114327)
Sandrahuguet   
2019-08-29 13:17   
code review + testing ok
(0114346)
hudsonbot   
2019-08-30 20:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/981eeb35474e [^]
Maturity status: Test
(0114458)
ngarcia   
2019-09-09 13:43   
(edited on: 2019-09-09 13:44)
With the current solution, cost adjustment lines are only posted if they belong to an organization that generates accounting in the general ledgers assigned to the document's organization.

Each transaction should generate accounting in the corresponding General Ledger.

I will update the steps to reproduce the situation
(0114505)
collazoandy4   
2019-09-10 16:50   
Test Plan IV
  As group admin role
    In Organization window, remove the General Ledger from 'F&B International Group' organization
    Assign 'F&B International Group US/A/US Dollar' general ledger to 'F&B US, Inc.' organization
    Create a new production product (Costing4) in * organization
       Add two purchase price of 5, one for Spain and Another for US
    Create a Goods Receipt in F&B España Region Norte for Costing4 product with 5 units
    Create another Goods Receipt in F&B US, East Coast for Costing4 product with 10 units
    Create a Goods Shipment in F&B US, East Coast for 10 units of Costing4 product
    Launch the costing background process and check the product transactions have cost calculated
    Add a manual cost adjustment to the transaction related to the goods receipt done in España Region Norte
    Go to the new cost adjustment created and Post it and check
      Accounting entries for F&B US East Cost organizations are only for F&B International Group US/A/US Dollar General Ledger
      Accounting entries for F&B España - Región Norte are for both general ledgers (F&B España, S.A. US/A/Euro and F&B International Group US/A/US Dollar)
(0114611)
hgbot   
2019-09-18 08:36   
Repository: erp/devel/pi
Changeset: 8051c60ae08c1a3b9469cb8cd32b403fe846e545
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Sep 18 08:29:08 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8051c60ae08c1a3b9469cb8cd32b403fe846e545 [^]

related to issue 41694 Backed out changeset bf50dc6daf1a

---
M src/org/openbravo/erpCommon/ad_forms/DocCostAdjustment.java
---
(0114644)
hudsonbot   
2019-09-18 15:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/39a64f55bfbd [^]
Maturity status: Test
(0114718)
Sandrahuguet   
2019-09-23 11:16   
Set as a design defect, the problem is that production has not been migrated to the new cost engine. See issue https://issues.openbravo.com/view.php?id=24530 [^]