Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041686Retail ModulesLoyalty Programs for Web POSpublic2019-08-23 14:312019-10-30 11:04
Reportermarkmm82 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041686: Polling when creating a subscription with card number does not always return data from the server
DescriptionSometimes after creating several subscriptions consecutively, the polling is failing and the response does not return from the server. This means that the data on the client is not updated correctly with the information generated on the server during the subscription processing (memberID, category, points earned by the subscription, etc.) and sometimes causes the user interfaces that remain waiting to show the updated data.

After the timeout passes, an error is shown in the browser log showing that the process of saving the subscription failed by the timeout.

When this happens, sometimes in the next subscription, the polling response brings the previous information (which failed) and the current subscription.

Specifically, this issue can be reproduced when the Card Number field is set in the subscription. After many iterations without defining this field at the time of creating the subscription (manual or automatic at the time of customers creation) could not be reproduced.

Right now this issue is making to fail some tests of the Loyalty Programs suite.
Attached you will find linf for two videos when this issue is reproduced randomly after some tries. It is needed sometimes more than 10 attempts to reproduce it. At try it is failing much more faster.

[1] https://drive.google.com/open?id=1d3WtinFy0NBK5kfQMCRSUzz1zPLev6Zd [^]
[2] https://drive.google.com/open?id=1m6p22yJZ1kRYY2kM03GWy0Eo8z1S6JAU [^]
Steps To ReproducePlease execute several times the same steps explained in Test Link [1]. Specially those wich are creating subscriptions with Card Numbers and are failing in Try:

[LPNR080] CardIsGeneratedWhenAddingNewSubscription
[LPNR090] CardGeneratedToAutomaticSubscriptionWhenCustomerIsCreated
[LPNR100] MultiCardFieldsWhenCustomerIsCreated
[LPNR170] CardExpirationDateAtAutomaticSubscription
[LPNR180] CardExpirationDateAtManualSubscription


[1] https://docs.google.com/spreadsheets/d/12Cbr5Kl1k1u6o_zZQzAxLCNbBgVLqW-RVThLxcT5GK0/edit#gid=562732981 [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0041811 closed gorka_gil Polling could be not launched due to asynchrony 
related to defect 0042102 closed Retail [LoyaltyPrograms] Error updating subscription number in WebPOS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-23 14:31markmm82New Issue
2019-08-23 14:31markmm82Assigned To => Retail
2019-08-23 14:31markmm82OBNetwork customer => No
2019-08-23 14:34markmm82Description Updatedbug_revision_view_page.php?rev_id=19328#r19328
2019-09-01 05:28hgbotCheckin
2019-09-01 05:28hgbotNote Added: 0114350
2019-09-18 04:00markmm82Note Added: 0114608
2019-09-18 04:01markmm82Fixed in SCM revision => https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/c663dcc8c5c1 [^]
2019-09-18 04:02markmm82Statusnew => scheduled
2019-09-18 04:02markmm82ProjectModules => Retail Modules
2019-09-18 04:04markmm82Triggers an Emergency Pack => No
2019-09-18 04:04markmm82CategoryLoyalty Programs => Loyalty Programs for Web POS
2019-09-18 04:04markmm82Note Added: 0114609
2019-09-18 04:04markmm82Statusscheduled => resolved
2019-09-18 04:04markmm82Fixed in Version => RR19Q4
2019-09-18 04:04markmm82Resolutionopen => fixed
2019-09-18 04:06markmm82Relationship addedcaused by 0041811
2019-09-18 08:15aferrazReview Assigned To => aferraz
2019-09-18 08:15aferrazStatusresolved => closed
2019-10-23 16:21SandrahuguetRelationship addedrelated to 0042102
2019-10-30 10:59aferrazAssigned ToRetail => markmm82
2019-10-30 11:04hgbotCheckin
2019-10-30 11:04hgbotNote Added: 0115342

Notes
(0114350)
hgbot   
2019-09-01 05:28   
Repository: tools/automation/pi-mobile
Changeset: 02857175b2b27501b7be56706db3fbebc657a53e
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Aug 23 09:52:13 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/02857175b2b27501b7be56706db3fbebc657a53e [^]

Related to issue 41686: Disable some loyalty subscriptions tests until polling is fixed

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR080_CardIsGeneratedWhenAddingNewSubscriptionWithCardNumberFieldDefined.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR090_CardGeneratedToAutomaticSubscriptionWhenCustomerIsCreated.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR100_MultiCardGeneratedToAutomaticSubscriptionWhenCustomerIsCreated.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR170_CardExpirationDateAtAutomaticSubscription.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR180_CardExpirationDateAtManualSubscription.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR270_MultiCardGeneratedToAutomaticSubscription.java
---
(0114608)
markmm82   
2019-09-18 04:00   
Fixed:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/c663dcc8c5c1 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9888c54aeb00 [^]
(0114609)
markmm82   
2019-09-18 04:04   
https://code.openbravo.com/erp/pmods/org.openbravo.retail.loyalty.programs/rev/c663dcc8c5c1 [^]
(0115342)
hgbot   
2019-10-30 11:04   
Repository: tools/automation/pi-mobile
Changeset: aebb598cf400a96a3254aa6311e100d7d882f2ed
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Oct 30 11:03:08 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/aebb598cf400a96a3254aa6311e100d7d882f2ed [^]

Related to issue 41686: Remove waitFixOf from LPNR270_MultiCardGeneratedToAutomaticSubscription test

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/loyalty/subscriptions/LPNR270_MultiCardGeneratedToAutomaticSubscription.java
---