Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041660ModulesAdvanced Warehouse Operationspublic2019-08-16 12:172019-08-20 13:24
Reporteravicente 
Assigned Tovmromanos 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041660: Confuse message when launch picking tasks from DO(i)
DescriptionWhen launching picking tasks for a distribution order issue, sometimes tasks are not created for all DO(i), for instance because there is not stock.

The process shows a green success message indicating the number of created tasks. As the message is green, the use thinks that all tasks have been created and he does not check the message. The message should be an orange warning message indicating that for the products XXX the tasks were not generated.
Steps To Reproduce0.Log into https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^] with the role AWO-QA Admin
1. Create a Distribution Order Issue with this values:
Header,
-Organization: US East Coast
-Warehouse Issue: US East Coast
-Warehouse Receipt: US West Coast
Line 1
-Manchego Cheese, 1 unit
Line 2
-Carrot, 1 unit
2. Click 'done' button.
3. click, 'Pick' button.

A green success message appears.
Proposed SolutionThe message should be an orange warning message indicating that for the products XXX the tasks were not generated.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0038534 new dmiguelez When no Batch of Tasks is generated, show proper message 
has duplicate design defect 0040013 closed vmromanos Improve warning message in window "Sales Order Lines Picking" 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-16 12:17avicenteNew Issue
2019-08-16 12:17avicenteAssigned To => Triage Finance
2019-08-16 12:46SandrahuguetAssigned ToTriage Finance => collazoandy4
2019-08-16 12:47SandrahuguetAssigned Tocollazoandy4 => vmromanos
2019-08-16 13:04vmromanosRelationship addedrelated to 0040013
2019-08-16 13:04vmromanosRelationship addedrelated to 0038534
2019-08-19 11:11vmromanosStatusnew => scheduled
2019-08-19 11:11vmromanosReview Assigned To => dmiguelez
2019-08-19 11:51vmromanosNote Added: 0114079
2019-08-19 12:07vmromanosNote Added: 0114081
2019-08-19 12:18hgbotCheckin
2019-08-19 12:18hgbotNote Added: 0114082
2019-08-19 12:18hgbotStatusscheduled => resolved
2019-08-19 12:18hgbotResolutionopen => fixed
2019-08-19 12:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/55c3ac0ef23d0f162a57165f63ebd504e32fd197 [^]
2019-08-19 12:18hgbotCheckin
2019-08-19 12:18hgbotNote Added: 0114083
2019-08-19 12:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/55c3ac0ef23d0f162a57165f63ebd504e32fd197 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/dba6d6b27cec6352b6013c8124b908b549b9ab07 [^]
2019-08-19 12:21vmromanosReview Assigned Todmiguelez => Sandrahuguet
2019-08-19 12:21vmromanosRelationship replacedhas duplicate 0040013
2019-08-20 13:24SandrahuguetNote Added: 0114100
2019-08-20 13:24SandrahuguetStatusresolved => closed
2022-09-06 17:18caristuCategoryAdvance Warehouse Operations => Advanced Warehouse Operations

Notes
(0114079)
vmromanos   
2019-08-19 11:51   
Note that this solution only fixes Sales Order and Distribution Order *Pickings*, ie other actions won't be improved. In those cases it shows a warning message when the CentralBroker is unable to create picking tasks for all the quantities within the document.

If no picking tasks are generated, the process will still show an error message.
(0114081)
vmromanos   
2019-08-19 12:07   
Test plan Sales Order:
With AWO sampledata
Login as AWO-QA Admin role
Go to Sales Order and create new record for West organization and West warehouse.
Create line with product Mango and quantity 100
Create line with product Ale Beer and quantity 500
Book the order
Press Pick.
Verify warning message is shown and it contains:
  Unable to generate picking for the following products:
  *Ale Beer: 450 Ud
  *Mango: 100 Ud
Press again Pick.
Verify No Batch of Tasks document was created Error is shown
Go to the generated picking list and delete it.



Test plan Distribution Order:
With AWO sampledata
Login as AWO-QA Admin role
Go to Distribution Order issue and create new record for West organization, West warehouse issue and East warehouse receipt.
Create line with product Mango and quantity 100
Create line with product Ale Beer and quantity 500
Book the distribution order
Press Pick.
Verify warning message is shown and it contains:
  Unable to generate picking for the following products:
  *Ale Beer: 450 Ud
  *Mango: 100 Ud
Verify No Batch of Tasks document was created Error is shown
Go to the generated picking list and delete it.
(0114082)
hgbot   
2019-08-19 12:18   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 55c3ac0ef23d0f162a57165f63ebd504e32fd197
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 19 12:15:36 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/55c3ac0ef23d0f162a57165f63ebd504e32fd197 [^]

Fixed issue 41660: Confuse message when launch picking tasks

After completing the creation of picking tasks, we use the obawoPendingQtyPicking column to detect the lines' quantity pending to generate picking. This is actually the quantities the CentralBroker was unable to create picking tasks for.
In this case a warning message is shown with the detailed information about the pending quantities. Example:

2 task(s) created successfully [Batch of Tasks document no. 1000171].
Picking list AWOPLST1000111 created successfully.
Unable to generate picking for the following products:
*Ale Beer: 461 Ud
*My Product: 7999 Ud

Added new aggregated function hqlaggbr, based on hqlagg, which adds a
as the aggregated string.
This is very convenient for displaying the warning message with new lines

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/warehouse/advancedwarehouseoperations/handler/PickingSalesOrderHandler.java
M src/org/openbravo/warehouse/advancedwarehouseoperations/init/AWOSQLFunctionRegister.java
---
(0114083)
hgbot   
2019-08-19 12:18   
Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders
Changeset: dba6d6b27cec6352b6013c8124b908b549b9ab07
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Aug 19 11:31:25 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/rev/dba6d6b27cec6352b6013c8124b908b549b9ab07 [^]

Fixed issue 41660: Confuse message when launch picking tasks

After completing the creation of picking tasks, we use the obdoaPendingQtyPicking column to detect the lines' quantity pending to generate picking. This is actually the quantities the CentralBroker was unable to create picking tasks for.
In this case a warning message is shown with the detailed information about the pending quantities. Example:

2 task(s) created successfully [Batch of Tasks document no. 1000171].
Picking list AWOPLST1000111 created successfully.
Unable to generate picking for the following products:
*Ale Beer: 461 Ud
*My Product: 7999 Ud

---
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/warehouse/advancedwarehouseoperations/distributionorders/handler/PickingDistributionOrderIssueHandler.java
---
(0114100)
Sandrahuguet   
2019-08-20 13:24   
code review + testing ok