Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041648Retail ModulesWeb POSpublic2019-08-14 09:492019-08-16 07:34
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q4Fixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041648: [NewDiscountEngine] Use JS classes to implement OB.DEC instead of regular functions
DescriptionAs part of the new discount engine proyect, it is necessary to implement OB.DEC from ob-arithmetic with js classes.

These change allows to create a in-middle js class called OB.BIGDEC that only operates with BigDecimals. These new API allows to operate without precision lost on intermediate numeric operations


OB.DEC should extend from OB.BIGDEC.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-14 09:49jorge-garciaNew Issue
2019-08-14 09:49jorge-garciaAssigned To => jorge-garcia
2019-08-14 09:49jorge-garciaOBNetwork customer => No
2019-08-14 09:49jorge-garciaTriggers an Emergency Pack => No
2019-08-14 09:50jorge-garciaDescription Updatedbug_revision_view_page.php?rev_id=19307#r19307
2019-08-14 09:53jorge-garciaStatusnew => scheduled
2019-08-14 09:53hgbotCheckin
2019-08-14 09:53hgbotNote Added: 0114006
2019-08-14 09:53hgbotStatusscheduled => resolved
2019-08-14 09:53hgbotResolutionopen => fixed
2019-08-14 09:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7b1fc16107d53e69aa40686b8de317c484507f8d [^]
2019-08-16 07:34marvintmReview Assigned To => marvintm
2019-08-16 07:34marvintmStatusresolved => closed
2019-08-16 07:34marvintmFixed in Version => RR19Q4

Notes
(0114006)
hgbot   
2019-08-14 09:53   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7b1fc16107d53e69aa40686b8de317c484507f8d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Aug 14 09:52:32 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7b1fc16107d53e69aa40686b8de317c484507f8d [^]

Fixed issue 41648: [NewDiscountEngine] Use JS classes to implement OB.DEC
instead of regular functions

This commit includes:
  * Refactor of ob-arithmetic to use javascript classes.
  * Include new calculation API called OB.BIGDEC to operate only
    with BigDecimals (no rounding or scale).

---
M web/org.openbravo.mobile.core/source/utils/ob-arithmetic.js
---