Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041619Openbravo ERP09. Financial managementpublic2019-08-08 20:152019-08-21 07:56
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041619: API Change: Remove unused methods from AdvPaymentMngtDao, FIN_Utility, PaymentReportDao
DescriptionMethods getReconciliationDetailReport and getReconciliationSummaryReport from AdvPaymentMngtDao,

getFinancialAccountList, getInStrList, getInStrSet, getOrderedPaymentDetailList and getPaymentMethodList from FIN_Utility

and getInvoicePaymentSchedule from PaymentReportDao are not used in Core as well as supported external modules hence risk of removing them is very low.

getInStrList method is used in below modules
- com.practicsbs.saftpt (No Information category)
- com.xpandit.openbravo.saftpt (Unsupported category)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks defect 0041425 closed AtulOpenbravo Unused methods in AdvPaymentMngtDao.java 
blocks defect 0041423 closed AtulOpenbravo The method getInvoicePaymentSchedule of PaymentReportDao.java is not used 
blocks defect 0041424 closed AtulOpenbravo Several unused methods in FIN_Utility.java 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-08 20:15AtulOpenbravoNew Issue
2019-08-08 20:15AtulOpenbravoAssigned To => Triage Finance
2019-08-08 20:15AtulOpenbravoModules => Core
2019-08-08 20:15AtulOpenbravoTriggers an Emergency Pack => No
2019-08-08 20:16AtulOpenbravoAssigned ToTriage Finance => dmitry_mezentsev
2019-08-08 20:20AtulOpenbravoRelationship addedblocks 0041425
2019-08-08 20:20AtulOpenbravoRelationship addedblocks 0041423
2019-08-08 20:21AtulOpenbravoRelationship addedblocks 0041424
2019-08-13 09:21dmitry_mezentsevTag Attached: Approved
2019-08-13 09:21dmitry_mezentsevAssigned Todmitry_mezentsev => AtulOpenbravo
2019-08-13 18:43hgbotCheckin
2019-08-13 18:43hgbotNote Added: 0113999
2019-08-13 18:43hgbotStatusnew => resolved
2019-08-13 18:43hgbotResolutionopen => fixed
2019-08-13 18:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/4ce568c079abbd6b1b6cc3942a3b2ddabd8214d9 [^]
2019-08-21 07:56vmromanosReview Assigned To => vmromanos
2019-08-21 07:56vmromanosNote Added: 0114107
2019-08-21 07:56vmromanosStatusresolved => closed
2019-08-21 07:56vmromanosFixed in Version => 3.0PR19Q4

Notes
(0113999)
hgbot   
2019-08-13 18:43   
Repository: erp/devel/api-checks
Changeset: 4ce568c079abbd6b1b6cc3942a3b2ddabd8214d9
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue Aug 13 22:09:30 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/4ce568c079abbd6b1b6cc3942a3b2ddabd8214d9 [^]

Fixes Issue 0041619: API Change: Remove unused methods from
AdvPaymentMngtDao, FIN_Utility, PaymentReportDao

Remove methods getReconciliationDetailReport & getReconciliationSummaryReport
from AdvPaymentMngtDao, getFinancialAccountList, getInStrList, getInStrSet,
getOrderedPaymentDetailList and getPaymentMethodList from FIN_Utility
and getInvoicePaymentSchedule from PaymentReportDao

---
M java/reference/java.japi.gz
---
(0114107)
vmromanos   
2019-08-21 07:56   
Code review OK.
CI passed successfully.