Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041582Retail ModulesWeb POSpublic2019-08-06 14:082019-09-19 13:44
Reporterngarcia 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket11246
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041582: Wrong discount information in JSON if a layaway includes a discount and the price in the backoffice is changed before paying it
DescriptionWrong discount information in JSON if a layaway includes a discount and the price in the backoffice is changed before paying it

"receiptlines" section includes the correct data
"lines" section includes wrong data

In order to see the consequence in the application, we are forcing the layaway to be editable from the Developers' tools
Steps To ReproduceIn the POS:
   Add a product
   Decrease its price
   Layaway this receipt

   Check in the Sales Order window that the following fields are correct:
      Gross List Price (original price)
      Gross Unit Price (modified price)
      Discount (different from 0)

In the backoffice:
   Change the price of the product to the decreased price

In the POS:
   Refresh
   Load the layaway
   Open the Developers tools and launch the following command:
      OB.MobileApp.model.receipt.turnEditable()
   Pay it

In the backoffice:
   Check the values in the Sales Order line are wrong:
      Gross List Price = Gross Unit Price
      Discount (different from 0)
Proposed Solution1) Check which field should be the one to be modified (Gross List Price or Discount)
2) Check the case with price lists that do not include taxes
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042237 closed rqueralta Discount value is not recalculated when opening a layaway with a price modification and editing it (not standard) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-06 14:08ngarciaNew Issue
2019-08-06 14:08ngarciaAssigned To => Retail
2019-08-06 14:08ngarciaOBNetwork customer => Gold
2019-08-06 14:08ngarciaSupport ticket => 11246
2019-08-06 14:08ngarciaResolution time => 1566856800
2019-08-06 14:08ngarciaTriggers an Emergency Pack => No
2019-08-09 15:08rqueraltaAssigned ToRetail => rqueralta
2019-08-16 13:25hgbotCheckin
2019-08-16 13:25hgbotNote Added: 0114039
2019-08-16 13:25hgbotStatusnew => resolved
2019-08-16 13:25hgbotResolutionopen => fixed
2019-08-16 13:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/accb6d7a842ee2704adc0edbb44b66b751da56a5 [^]
2019-09-02 09:22marvintmReview Assigned To => marvintm
2019-09-02 09:22marvintmStatusresolved => closed
2019-09-02 09:22marvintmFixed in Version => RR19Q4
2019-09-06 15:29hgbotCheckin
2019-09-06 15:29hgbotNote Added: 0114440
2019-09-06 15:44hgbotCheckin
2019-09-06 15:44hgbotNote Added: 0114441
2019-09-10 12:14malsasuaNote Added: 0114491
2019-09-10 12:14malsasuaStatusclosed => new
2019-09-10 12:14malsasuaResolutionfixed => open
2019-09-10 12:14malsasuaFixed in VersionRR19Q4 =>
2019-09-10 12:14malsasuaResolution time1566856800 => 1568671200
2019-09-13 16:30hgbotCheckin
2019-09-13 16:30hgbotNote Added: 0114575
2019-09-13 16:30hgbotStatusnew => resolved
2019-09-13 16:30hgbotResolutionopen => fixed
2019-09-13 16:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/accb6d7a842ee2704adc0edbb44b66b751da56a5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcc970e22d40b8980fc848a71f04ff27a7711a54 [^]
2019-09-17 21:45hgbotCheckin
2019-09-17 21:45hgbotNote Added: 0114603
2019-09-19 13:44marvintmStatusresolved => closed
2019-09-19 13:44marvintmFixed in Version => RR19Q4
2019-11-08 13:37ngarciaRelationship addedrelated to 0042237

Notes
(0114039)
hgbot   
2019-08-16 13:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: accb6d7a842ee2704adc0edbb44b66b751da56a5
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Aug 15 18:26:53 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/accb6d7a842ee2704adc0edbb44b66b751da56a5 [^]

Fixed issue 41582: Wrong discount information in JSON if a layaway includes a
discount and the price in the backoffice is changed before paying it

- Updated the gross list price value with the product list price value

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0114440)
hgbot   
2019-09-06 15:29   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: c99338e1032a639c4520fa88b9e67856bf8865d9
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Aug 26 11:54:20 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/c99338e1032a639c4520fa88b9e67856bf8865d9 [^]

Added sampledata for testing issue 41582

---
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_STORAGE_DETAIL.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
---
(0114441)
hgbot   
2019-09-06 15:44   
Repository: tools/automation/pi-mobile
Changeset: baf5f96a1f4b4168bf52cf5d2532176ec956718a
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Sep 06 09:44:05 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/baf5f96a1f4b4168bf52cf5d2532176ec956718a [^]

Related to issue 41582: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I41582_VerifyLayawayDiscountIfPriceChangedBeforePaying.java
---
(0114491)
malsasua   
2019-09-10 12:14   
price list amount should be retrieved from backoffice-> sales order line
(0114575)
hgbot   
2019-09-13 16:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: bcc970e22d40b8980fc848a71f04ff27a7711a54
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Wed Sep 11 15:14:08 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/bcc970e22d40b8980fc848a71f04ff27a7711a54 [^]

Fixed issue 41582: Wrong discount information in JSON if a layaway includes a
discount and the price in the backoffice is changed before paying it

- Updated the gross list price value with the line list price value

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0114603)
hgbot   
2019-09-17 21:45   
Repository: tools/automation/pi-mobile
Changeset: 36cc966a697fde9e8e223521dea4b5fd0b141b83
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Sep 17 15:42:38 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/36cc966a697fde9e8e223521dea4b5fd0b141b83 [^]

Fixed issue 41791: fixed test and sampledata for issue 41582

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I41582_VerifyLayawayDiscountIfPriceChangedBeforePaying.java
---