Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041524Openbravo ERPA. Platformpublic2019-08-01 13:182019-08-22 14:45
Reporterplujan 
Assigned Tojarmendariz 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2018-11-19
Regression introduced in release3.0PR19Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4d00819f3952ff85dae35810a6a47c2f2bbfaed8 [^]
Triggers an Emergency PackNo
Summary0041524: Errors in build from UI are not shown
DescriptionI am rebuilding the system after installing a module. It seems the module has some dependency issue, but the expected message of error is not shown. Instead, from the GUI seems the rebuild was successful, while the log is showing that it was not.
Steps To ReproduceIn order to reproduce the issue it is required to install via the MMC a module with an error like this one:
[java] org.apache.ddlutils.model.ModelException: The foreignkey EM_OBRESMS_ORDER_RESERVATION in table C_ORDER references the undefined table OBRE_RESERVATION

Launching the Rebuild process, it finishes (or seems to finish) successfully, since a green banner "Process Completed Successfully" is shown. But looking at the log shows a different story (the error message shown above is from the log)

For more information, check the attached screenshot. The full log is also available on demad.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00415463.0PR19Q3 closed jarmendariz Errors in build from UI are not shown 
depends on backport 00415473.0PR19Q2.2 closed jarmendariz Errors in build from UI are not shown 
depends on backport 00415483.0PR19Q1.3 closed jarmendariz Errors in build from UI are not shown 
caused by feature request 0039504 closed jarmendariz Upgrade Log4j to version 2 
caused by design defect 0039034 closed caristu Illegal Access warning in xstream-1.3.1 library 
has duplicate defect 0040949 closed platform The system build from the app fails but shows a success message 
Attached Filespng FailedRebuildSuccessful.png (56,135) 2019-08-01 13:18
https://issues.openbravo.com/file_download.php?file_id=13199&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-08-01 13:18plujanNew Issue
2019-08-01 13:18plujanAssigned To => platform
2019-08-01 13:18plujanFile Added: FailedRebuildSuccessful.png
2019-08-01 13:18plujanModules => Core
2019-08-01 13:18plujanTriggers an Emergency Pack => No
2019-08-05 12:49jarmendarizRelationship addedcaused by 0039504
2019-08-05 12:49jarmendarizAssigned Toplatform => jarmendariz
2019-08-05 13:02jarmendarizRegression level => Production - Confirmed Stable
2019-08-05 13:02jarmendarizRegression introduced in release => 3.0PR19Q1
2019-08-05 13:24jarmendarizStatusnew => scheduled
2019-08-05 13:53hgbotCheckin
2019-08-05 13:53hgbotNote Added: 0113813
2019-08-05 13:53hgbotStatusscheduled => resolved
2019-08-05 13:53hgbotResolutionopen => fixed
2019-08-05 13:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/abfb012807e402f384506ea4ff03dd258fafd818 [^]
2019-08-05 13:55jarmendarizSummary[19Q3] A failed rebuild shows a success message => Errors in build from UI are not shown
2019-08-06 10:53alostaleRelationship addedhas duplicate 0040949
2019-08-06 10:58jarmendarizNote Added: 0113827
2019-08-06 11:03jarmendarizRegression date => 2018-11-19
2019-08-06 11:03jarmendarizRegression introduced by commit => 4d00819f3952ff85dae35810a6a47c2f2bbfaed8
2019-08-06 11:05jarmendarizRegression introduced by commit4d00819f3952ff85dae35810a6a47c2f2bbfaed8 => https://code.openbravo.com/erp/devel/pi/rev/4d00819f3952ff85dae35810a6a47c2f2bbfaed8 [^]
2019-08-06 13:33alostaleRelationship addedcaused by 0039034
2019-08-06 13:33alostaleReview Assigned To => alostale
2019-08-06 13:33alostaleNote Added: 0113843
2019-08-06 13:33alostaleStatusresolved => closed
2019-08-06 13:33alostaleFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114203

Notes
(0113813)
hgbot   
2019-08-05 13:53   
Repository: erp/devel/pi
Changeset: abfb012807e402f384506ea4ff03dd258fafd818
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Fri Aug 02 14:44:36 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/abfb012807e402f384506ea4ff03dd258fafd818 [^]

Fixed issue 41524: Errors in build from UI are not shown

Log4j configuration is missing in BuildTask ant task. This causes
that when this task fails, the error message is not passed to
OBRebuildAppender and thus the process finishes as successful from
the point of view of the UI.

---
M build.xml
M src-core/src/org/openbravo/utils/OBRebuildAppender.java
M src/org/openbravo/erpCommon/ad_process/ApplyModulesResponse.java
---
(0113827)
jarmendariz   
2019-08-06 10:58   
Created a test scenario in TestLink:
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-11546 [^]
(0113843)
alostale   
2019-08-06 13:33   
reviewed + tested
(0114203)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test