Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0004151Openbravo ERPZ. Otherspublic2008-06-24 16:472008-10-08 18:35
user71 
gorka_gil 
urgentminoralways
closedfixed 
5
 
2.35MP7 
OBPS
Core
No
0004151: System.gc() should never be called
Openbravo starts a thread that explictly invokes the garbage collector and finalization functions.

This is not good practice & won't actually help clean up database connections.
In addition it means that there is a thread running that won't be shutdown properly when the app is undeployed or redeployed.

I think the PeriodicGarbageCollector class should be removed entirely.
OBN
blocks defect 0002084 closed alostale System.gc() should never be called 
Issue History
2008-06-24 16:47cromeroNew Issue
2008-06-24 16:47cromeroAssigned To => alostale
2008-06-24 16:47cromeroStatusnew => scheduled
2008-06-24 16:49cromeroTag Attached: OBN
2008-06-24 16:49cromeroOBNetwork customer => Yes
2008-06-24 16:49cromeroPrioritynormal => urgent
2008-06-24 16:49cromeroDescription Updated
2008-06-24 18:04cromeroStatusscheduled => feedback
2008-06-27 12:22cromeroStatusfeedback => scheduled
2008-06-30 11:15gorka_gilAssigned Toalostale => gorka_gil
2008-06-30 12:09svnbotCheckin
2008-06-30 12:09svnbotNote Added: 0008067
2008-06-30 12:09svnbotStatusscheduled => resolved
2008-06-30 12:09svnbotResolutionopen => fixed
2008-06-30 12:09svnbotsvn_revision => 5482
2008-10-08 18:35psarobeRegression testing => No
2008-10-08 18:35psarobeStatusresolved => closed

Notes
(0008067)
svnbot   
2008-06-30 12:09   
Repository: openbravo
Revision: 5482
Author: gorka_gil
Date: 2008-06-30 12:09:24 +0200 (Mon, 30 Jun 2008)

fixed bug 4151 Remove PeriodicGarbageCollector class

---
U branches/r2.3x/src-core/src/org/openbravo/base/HttpBaseServlet.java
D branches/r2.3x/src-core/src/org/openbravo/base/PeriodicGarbageCollector.java
---

https://dev.openbravo.com/websvn/openbravo/?rev=5482&sc=1 [^]