Openbravo Issue Tracking System - Retail Modules
View Issue Details
0041488Retail ModulesGift cards and gift voucherspublic2019-07-31 07:522019-08-16 07:46
migueldejuana 
migueldejuana 
normalmajoralways
closedfixed 
5
 
RR19Q4 
marvintm
No
0041488: Remove a GiftCard payment when it is not in backend
Now, when adding a Gift Card/Gift Certificate/Credit Note payment, if we do not get answer from backend, we assume that it is consumed. In case it is not consumed we will consume when processing the order.
If we try to remove it and it is not processed in the backend we get an error, in that case, assume that it is not processed yet and just remove it.
- Add a product
- Open gift card amount payment popup and select one without applying it
- Go offline
- Add a Gift Card Certificate payment (Apply)
- The consume is not done yet
- Remove added payment
- ERROR! We cannot remove it because it doen't find the trans Id
No tags attached.
Issue History
2019-07-31 07:52migueldejuanaNew Issue
2019-07-31 07:52migueldejuanaAssigned To => migueldejuana
2019-07-31 07:52migueldejuanaTriggers an Emergency Pack => No
2019-07-31 07:55hgbotCheckin
2019-07-31 07:55hgbotNote Added: 0113721
2019-07-31 07:55hgbotStatusnew => resolved
2019-07-31 07:55hgbotResolutionopen => fixed
2019-07-31 07:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9bcaf29c4197b918ad4548c47b9463e3f809a8b9 [^]
2019-08-16 07:46marvintmReview Assigned To => marvintm
2019-08-16 07:46marvintmStatusresolved => closed
2019-08-16 07:46marvintmFixed in Version => RR19Q4

Notes
(0113721)
hgbot   
2019-07-31 07:55   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 9bcaf29c4197b918ad4548c47b9463e3f809a8b9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Wed Jul 31 07:54:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/9bcaf29c4197b918ad4548c47b9463e3f809a8b9 [^]

Fixed issue 0041488: Remove a GiftCard payment when it is not in backend

- If trans Id doesn't exists, do not respond error, send success with a flag giftCardTransactionNotExists

---
M src/org/openbravo/retail/giftcards/RevertGiftCardAmount.java
M web/org.openbravo.retail.giftcards/js/hooks/preremovepaymenthook.js
---