Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041439Openbravo ERPA. Platformpublic2019-07-23 16:122019-07-26 08:38
Reportercberner 
Assigned Tocberner 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q3Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelCoding ( Testing )
Regression date2019-05-20
Regression introduced in releasemain
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/4dc58edab48f2f9e20cfce74f557827e43919803 [^]
Triggers an Emergency PackNo
Summary0041439: Process.getADProcessParameterList has been removed and was in use
DescriptionAs part of this issue [1], some one-to-many child methods were removed, assuming that they were not in use.

But the service contract module was found to be using Process.getADProcessParameterList, resulting in a build error.

[1] https://issues.openbravo.com/view.php?id=40906 [^]
Steps To Reproduce- Install the service contract module [1] and its dependencies: Contract management infrastructure [2]
- Compile: ant smartbuild -Dlocal=no
- The following error is shown in the log:

compileSqlc:
    [javac] Compiling 72 source files to /home/openbravo/ws/pi/openbravo/build/classes
    [javac] /home/openbravo/ws/pi/openbravo/modules/org.openbravo.contract.services/src/org/openbravo/contract/services/process/dao/ProcessServiceContractBackgroundDao.java:70: error: cannot find symbol
    [javac] return OBDal.getInstance().get(Process.class, processId).getADProcessParameterList().get(0)
    [javac] ^
    [javac] symbol: method getADProcessParameterList()
    [javac] location: class Process
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 error

[1] https://code.openbravo.com/erp/pmods/org.openbravo.contract.services [^]
[2] https://code.openbravo.com/erp/mods/org.openbravo.contract [^]
Proposed SolutionChange the IS_CHILD_PROPERTY_IN_PARENT to Y for the problematic column, so that its child property is included in its parent entity.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0041438 closed cberner Process.getADProcessParameterList has been removed and was in use 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-23 16:16cbernerTypedefect => backport
2019-07-23 16:16cbernerTarget Version => 3.0PR19Q3
2019-07-23 16:36cbernerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19184#r19184
2019-07-26 08:38hgbotCheckin
2019-07-26 08:38hgbotNote Added: 0113664
2019-07-26 08:38hgbotStatusscheduled => resolved
2019-07-26 08:38hgbotResolutionopen => fixed
2019-07-26 08:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/8ec0f1dbef30ff1ac876df5d5d427898ca72498f [^]
2019-07-26 08:38AugustoMauchReview Assigned To => AugustoMauch
2019-07-26 08:38AugustoMauchNote Added: 0113666
2019-07-26 08:38AugustoMauchStatusresolved => closed

Notes
(0113664)
hgbot   
2019-07-26 08:38   
Repository: erp/backports/3.0PR19Q3
Changeset: 8ec0f1dbef30ff1ac876df5d5d427898ca72498f
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Wed Jul 24 09:37:57 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/8ec0f1dbef30ff1ac876df5d5d427898ca72498f [^]

fixes issue 41439: Process.getADProcessParameterList is generated again

Flag IS_CHILD_PROPERTY_IN_PARENT has been changed to Y on column AD_Process_ID in table ADProcessParameter
so it generates Process.getADProcessParameterList again. Fixes module "service contract".

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0113666)
AugustoMauch   
2019-07-26 08:38   
Code reviewed and verified