Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041438Openbravo ERPA. Platformpublic2019-07-23 16:122019-08-22 14:45
cberner 
cberner 
immediatecriticalhave not tried
closedfixed 
5
 
 
AugustoMauch
Core
Coding ( Testing )
2019-05-20
main
http://code.openbravo.com/erp/devel/pi/rev/4dc58edab48f2f9e20cfce74f557827e43919803 [^]
No
0041438: Process.getADProcessParameterList has been removed and was in use
As part of this issue [1], some one-to-many child methods were removed, assuming that they were not in use.

But the service contract module was found to be using Process.getADProcessParameterList, resulting in a build error.

[1] https://issues.openbravo.com/view.php?id=40906 [^]
- Install the service contract module [1] and its dependencies: Contract management infrastructure [2]
- Compile: ant smartbuild -Dlocal=no
- The following error is shown in the log:

compileSqlc:
    [javac] Compiling 72 source files to /home/openbravo/ws/pi/openbravo/build/classes
    [javac] /home/openbravo/ws/pi/openbravo/modules/org.openbravo.contract.services/src/org/openbravo/contract/services/process/dao/ProcessServiceContractBackgroundDao.java:70: error: cannot find symbol
    [javac] return OBDal.getInstance().get(Process.class, processId).getADProcessParameterList().get(0)
    [javac] ^
    [javac] symbol: method getADProcessParameterList()
    [javac] location: class Process
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 error

[1] https://code.openbravo.com/erp/pmods/org.openbravo.contract.services [^]
[2] https://code.openbravo.com/erp/mods/org.openbravo.contract [^]
Change the IS_CHILD_PROPERTY_IN_PARENT to Y for the problematic column, so that its child property is included in its parent entity.
No tags attached.
depends on backport 00414393.0PR19Q3 closed cberner Process.getADProcessParameterList has been removed and was in use 
Issue History
2019-07-23 16:12cbernerNew Issue
2019-07-23 16:12cbernerAssigned To => cberner
2019-07-23 16:12cbernerModules => Core
2019-07-23 16:12cbernerRegression level => Coding ( Testing )
2019-07-23 16:12cbernerRegression date => 2019-05-20
2019-07-23 16:12cbernerRegression introduced in release => main
2019-07-23 16:12cbernerRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/4dc58edab48f2f9e20cfce74f557827e43919803 [^]
2019-07-23 16:12cbernerTriggers an Emergency Pack => No
2019-07-23 16:16cbernerStatusnew => scheduled
2019-07-23 16:36cbernerSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19182#r19182
2019-07-26 08:32hgbotCheckin
2019-07-26 08:32hgbotNote Added: 0113661
2019-07-26 08:32hgbotStatusscheduled => resolved
2019-07-26 08:32hgbotResolutionopen => fixed
2019-07-26 08:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ac845caf1e70733f1a3ca6f7677367e0b05a5fee [^]
2019-07-26 08:38AugustoMauchReview Assigned To => AugustoMauch
2019-07-26 08:38AugustoMauchNote Added: 0113667
2019-07-26 08:38AugustoMauchStatusresolved => closed
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114177

Notes
(0113661)
hgbot   
2019-07-26 08:32   
Repository: erp/devel/pi
Changeset: ac845caf1e70733f1a3ca6f7677367e0b05a5fee
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Tue Jul 23 17:43:08 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ac845caf1e70733f1a3ca6f7677367e0b05a5fee [^]

fixes issue 41438: Process.getADProcessParameterList is generated again

Flag IS_CHILD_PROPERTY_IN_PARENT has been changed to Y on column AD_Process_ID in table ADProcessParameter
so it generates Process.getADProcessParameterList again. Fixes module "service contract".

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0113667)
AugustoMauch   
2019-07-26 08:38   
Code reviewed and verified
(0114177)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test