Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041429ModulesExternal Integration Infrastructurepublic2019-07-23 11:122019-08-02 09:16
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToAugustoMauch
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041429: Not possible to define a Date property mappings to identify a record univocally
DescriptionIt is not possible to define a Date property mappings to identify a record univocally.

When a property mapping of type "DateDirectPropertyMapping" is marked as "Identifies Record Univocally", the import of the SBO fails with the following error:

"java.lang.ClassCastException: java.base/java.lang.String cannot be cast to java.base/java.util.Date"
Steps To Reproduce0) Install the external integration module for testing[1]
1) Apply the attached patch
2) Execute ant smartbuild -Dlocal=no
3) Run the PriceListImportTest test. It works.
4) Execute the test again. Note that it fails with the error mentioned in Description. Subsequent executions will also fail.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration.tests [^]
    
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff test_41429.diff (1,711) 2019-07-23 11:14
https://issues.openbravo.com/file_download.php?file_id=13166&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-23 11:12caristuNew Issue
2019-07-23 11:12caristuAssigned To => caristu
2019-07-23 11:12caristuIssue generated from0041427
2019-07-23 11:13caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19174#r19174
2019-07-23 11:14caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19175#r19175
2019-07-23 11:14caristuFile Added: test_41429.diff
2019-07-23 12:28hgbotCheckin
2019-07-23 12:28hgbotNote Added: 0113588
2019-07-23 12:31hgbotCheckin
2019-07-23 12:31hgbotNote Added: 0113589
2019-07-23 12:31hgbotStatusnew => resolved
2019-07-23 12:31hgbotResolutionopen => fixed
2019-07-23 12:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/53ea9eeefa789510b37e87a0a6e6d5b6ce5b4e64 [^]
2019-07-23 12:33caristuReview Assigned To => AugustoMauch
2019-07-29 11:06AugustoMauchNote Added: 0113686
2019-07-29 11:06AugustoMauchStatusresolved => new
2019-07-29 11:06AugustoMauchResolutionfixed => open
2019-08-02 08:26hgbotCheckin
2019-08-02 08:26hgbotNote Added: 0113770
2019-08-02 08:27caristuStatusnew => scheduled
2019-08-02 08:27caristuStatusscheduled => resolved
2019-08-02 08:27caristuResolutionopen => fixed
2019-08-02 09:16AugustoMauchNote Added: 0113775
2019-08-02 09:16AugustoMauchStatusresolved => closed

Notes
(0113588)
hgbot   
2019-07-23 12:28   
Repository: erp/pmods/org.openbravo.service.external.integration.tests
Changeset: b7fc84b4a77382d6d83b3a5413f208d58047fac3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jul 23 12:28:44 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration.tests/rev/b7fc84b4a77382d6d83b3a5413f208d58047fac3 [^]

related to issue 41429: set Date property as identifies univocally

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0113589)
hgbot   
2019-07-23 12:31   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: 53ea9eeefa789510b37e87a0a6e6d5b6ce5b4e64
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jul 23 12:29:56 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/53ea9eeefa789510b37e87a0a6e6d5b6ce5b4e64 [^]

fixes bug 41429: Support for Date properties to identify a record univocally

---
M src/org/openbravo/service/external/integration/SynchronizableBusinessObject.java
M src/org/openbravo/service/external/integration/importer/DalSynchronizableBusinessObjectImporter.java
---
(0113686)
AugustoMauch   
2019-07-29 11:06   
It would be useful to also support using DateTime properties to identify records univocally
(0113770)
hgbot   
2019-08-02 08:26   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: 3d0c7c76097b062069409e52a33df817d5d50544
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Aug 02 08:23:42 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/3d0c7c76097b062069409e52a33df817d5d50544 [^]

related to bug 41429: support DateTime as identifies univocally

  Now DateTime mappings can be configured to identify a record univocally.

  Some minor code improvements has also been applied

---
M src/org/openbravo/service/external/integration/SynchronizableBusinessObject.java
---
(0113775)
AugustoMauch   
2019-08-02 09:16   
Code reviewed and verified