Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041427ModulesExternal Integration Infrastructurepublic2019-07-23 10:042019-07-29 11:07
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToAugustoMauch
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041427: Not possible to define one-to-many mappings for some entities
DescriptionIt is not possible to define one-to-many mappings from those entities whose entity name is different from its simple class name.
Steps To Reproduce0) Install the external integration module for testing[1]
1) Apply the attached patch
2) Execute ant smartbuild -Dlocal=no
3) Run the PriceListImportTest test. Note that it fails with the following error:

org.openbravo.base.util.CheckException: Mapping name: PriceListVersion not found in runtime model

[1] https://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration.tests [^]
    
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff test_41427.diff (19,580) 2019-07-23 10:30
https://issues.openbravo.com/file_download.php?file_id=13165&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-23 10:04caristuNew Issue
2019-07-23 10:04caristuAssigned To => platform
2019-07-23 10:04caristuAssigned Toplatform => caristu
2019-07-23 10:05caristuFile Added: test_41427.diff
2019-07-23 10:29caristuFile Deleted: test_41427.diff
2019-07-23 10:30caristuFile Added: test_41427.diff
2019-07-23 10:45hgbotCheckin
2019-07-23 10:45hgbotNote Added: 0113586
2019-07-23 10:45hgbotStatusnew => resolved
2019-07-23 10:45hgbotResolutionopen => fixed
2019-07-23 10:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/a38e295dbf54248dc1ca1e771e5e7289a5912efc [^]
2019-07-23 10:48hgbotCheckin
2019-07-23 10:48hgbotNote Added: 0113587
2019-07-23 10:49caristuReview Assigned To => AugustoMauch
2019-07-23 10:50caristuSummaryNot possible to define one-to-many mappings from some entities => Not possible to define one-to-many mappings for some entities
2019-07-23 11:12caristuIssue cloned0041429
2019-07-23 11:12caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19172#r19172
2019-07-29 11:07AugustoMauchNote Added: 0113687
2019-07-29 11:07AugustoMauchStatusresolved => closed

Notes
(0113586)
hgbot   
2019-07-23 10:45   
Repository: erp/pmods/org.openbravo.service.external.integration
Changeset: a38e295dbf54248dc1ca1e771e5e7289a5912efc
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jul 23 10:38:55 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration/rev/a38e295dbf54248dc1ca1e771e5e7289a5912efc [^]

fixes bug 41427: Not possible to define one-to-many mappings from some entities

  When looking for the parent property, now we directly use the entity name defined in the mapping instead of the class simple name. This allows to define one-to-many mappings referencing to entities whose simple class name is different from the entity name itself.

  Besides, this change allows us to simplify the signature of some methods of the SynchronizableBusinessObjectImporter class.

---
M src/org/openbravo/service/external/integration/importer/DalSynchronizableBusinessObjectImporter.java
---
(0113587)
hgbot   
2019-07-23 10:48   
Repository: erp/pmods/org.openbravo.service.external.integration.tests
Changeset: b72b168a771223e7f3e88a6c41064635eef4ceda
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jul 23 10:48:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.service.external.integration.tests/rev/b72b168a771223e7f3e88a6c41064635eef4ceda [^]

related to bug 41427: add test case

---
M src-db/database/sourcedata/OBEI_ENTITY_MAPPING.xml
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
M src-test/org/openbravo/service/external/integration/test/ExternalIntegrationTestSuite.java
M src-test/org/openbravo/service/external/integration/test/TestConstants.java
A src-test/org/openbravo/service/external/integration/test/_import/PriceListImportTest.java
---
(0113687)
AugustoMauch   
2019-07-29 11:07   
Code reviewed and verified