Openbravo Issue Tracking System - Openbravo ERP | ||||||||||||
| View Issue Details | ||||||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | |||||||
| 0041422 | Openbravo ERP | Z. Others | public | 2019-07-22 20:45 | 2020-01-30 14:41 | |||||||
| Reporter | AtulOpenbravo | |||||||||||
| Assigned To | AtulOpenbravo | |||||||||||
| Priority | normal | Severity | minor | Reproducibility | have not tried | |||||||
| Status | closed | Resolution | fixed | |||||||||
| Platform | OS | 5 | OS Version | |||||||||
| Product Version | ||||||||||||
| Target Version | Fixed in Version | 3.0PR20Q1 | ||||||||||
| Merge Request Status | ||||||||||||
| Review Assigned To | aferraz | |||||||||||
| OBNetwork customer | ||||||||||||
| Web browser | ||||||||||||
| Modules | Core | |||||||||||
| Support ticket | ||||||||||||
| Regression level | ||||||||||||
| Regression date | ||||||||||||
| Regression introduced in release | ||||||||||||
| Regression introduced by commit | ||||||||||||
| Triggers an Emergency Pack | No | |||||||||||
| Summary | 0041422: API Change: Old Costing Cleanup | |||||||||||
| Description | Following are the candidates that could be removed as they belong to old costing feature -Sales Invoice Dimensional Report Legacy -Generate Average Costs -Valued Stock Report Legacy -Create Production Costs -Pareto Product Report Legacy -Costing Migration Process -Costing Status -M_UPDATE_PARETO_PRODUCT_LEGACY **Remove related DB functions, Menu's, Model Object and their Mapping, unused html files, xml files, xsql, java classes & methods, ad_elements, text interfaces, messages etc. *Missing class -org.openbravo.costing.CostingMigrationProcess -org.openbravo.costing.CostingStatus -org.openbravo.erpCommon.ad_reports.ReportInvoiceCustomerDimensionalAnalysesJR_legacy -org.openbravo.erpCommon.ad_reports.ReportParetoProductLegacy -org.openbravo.erpCommon.ad_reports.ReportValuationStock_legacy *Missing methods -org.openbravo.erpCommon.reference.ActionButtonData.process1000500001(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.erpCommon.reference.ActionButtonData.process182(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.erpCommon.reference.ActionButtonData.process800085(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.erpCommon.reference.ActionButtonData.process800151(org.openbravo.database.ConnectionProvider, java.lang.String) -org.openbravo.model.materialmgmt.cost.Costing.getGoodsShipmentLine() -org.openbravo.model.materialmgmt.cost.Costing.getProductionLine() -org.openbravo.model.materialmgmt.cost.Costing.setGoodsShipmentLine(org.openbravo.model.materialmgmt.transaction.ShipmentInOutLine) -org.openbravo.model.materialmgmt.cost.Costing.setProductionLine(org.openbravo.model.materialmgmt.transaction.ProductionLine) -org.openbravo.model.common.plm.Product.getCostType() -org.openbravo.model.common.plm.Product.getStandardCost() -org.openbravo.model.common.plm.Product.setCostType(java.lang.String) -org.openbravo.model.common.plm.Product.setStandardCost(java.math.BigDecimal) *Missing Fields -org.openbravo.model.common.plm.Product.PROPERTY_COSTTYPE -org.openbravo.model.common.plm.Product.PROPERTY_STANDARDCOST -org.openbravo.model.materialmgmt.cost.Costing.PROPERTY_GOODSSHIPMENTLINE -org.openbravo.model.materialmgmt.cost.Costing.PROPERTY_PRODUCTIONLINE **Below references in external modules found A. CostingStatus allMods-SUP/org.openbravo.warehouse.reportvaluedstockenhanced, ReportValuedStockEnhanced.java class line no 34 allMods-NI/br.com.disoft.brazil.ce.core, InvoiceCustomerDimensionalAnalysesJR.java class line no 299 Need to remove if loop which has CostingStatus.IsMigrated == false check, it wont be never executed. It is safe to remove. B. Product : CostType (setCostType() method) i. allMods-SUP/org.openbravo.module.idljava SampleProductsProcess.java class, line no204. ii. allMods-SUP/org.openbravo.service.integration.sap.ecc.mappings, ProductOBObjectInitializer.java class, line no 29 iii. allMods-NI/com.tds.openbravo.magento, ProductSynchronization.java class, line no 19 Only set method is use and get method is not, hence safe to remove. iv. allMods-NI/fr.phidias.openbravo.retail: m_product.costtype is used in view PHPOS_PRODUCT_V, PHPOS_PRODUCTPRICE_V v. allMods-NI/org.wirabumi.gen.oez: m_product.costtype is used in function OEZ_IMPORTPRODUCTCOST as below: --get costtype select costtype into v_costtype from m_product where m_product_id=cur_productcost.m_product_id; if v_costtype is null then v_costtype='AV'; --default costtype is Average update m_product set costtype='AV' where m_product_id=cur_productcost.m_product_id; --updating costtype end if; C. Product: CostStd (setStandardCost() method) i. allMods-SUP/org.openbravo.module.idljava, SampleProductsProcess.java class, line no 224 ii. allMods-NI/com.tds.openbravo.magento, ProductSynchronization.java class, line no 69 & 71 Only set method is use and get method is not, hence safe to remove. iii. allMods-NI/fr.phidias.openbravo.retail: m_product.coststd is used in view PHPOS_PRODUCT_V, PHPOS_PRODUCTPRICE_V D. DB Function: M_GENERATE_AVERAGE_COSTS i. allMods-NI/com.sidesoft.localization.ecuador.withholdings, SSWH_GENERATE_STATUS, line no 122 ii. allMods-NI/com.sidesoft.localization.ecuador.withholdings, SSWH_GENERATE_CHECK, line no 161 The above two functions uses M_GENERATE_AVERAGE_COSTS but the piece of code is commented. Hence removal is safe. - Sample data changes related to removed column's, process access can be managed in Core, Retail Sample Data & AWP Sample Data modules, hence removing of the above deletion candidate has low risk. | |||||||||||
| Steps To Reproduce | - | |||||||||||
| Proposed Solution | ||||||||||||
| Additional Information | ||||||||||||
| Tags | Approved | |||||||||||
| Relationships |
| |||||||||||
| Attached Files | ||||||||||||
| Issue History | ||||||||||||
| Date Modified | Username | Field | Change | |||||||||
| 2019-07-22 20:45 | AtulOpenbravo | New Issue | ||||||||||
| 2019-07-22 20:45 | AtulOpenbravo | Assigned To | => Triage Finance | |||||||||
| 2019-07-22 20:45 | AtulOpenbravo | Modules | => Core | |||||||||
| 2019-07-22 20:45 | AtulOpenbravo | Triggers an Emergency Pack | => No | |||||||||
| 2019-07-22 20:46 | AtulOpenbravo | Relationship added | blocks 0041421 | |||||||||
| 2019-07-22 22:29 | AtulOpenbravo | Description Updated | bug_revision_view_page.php?rev_id=19167#r19167 | |||||||||
| 2019-07-22 22:31 | AtulOpenbravo | Description Updated | bug_revision_view_page.php?rev_id=19170#r19170 | |||||||||
| 2019-09-24 10:38 | AtulOpenbravo | Review Assigned To | => dmitry_mezentsev | |||||||||
| 2019-09-24 10:38 | AtulOpenbravo | Description Updated | bug_revision_view_page.php?rev_id=19400#r19400 | |||||||||
| 2019-09-24 17:07 | dmitry_mezentsev | Tag Attached: Approved | ||||||||||
| 2019-10-04 14:09 | aferraz | Assigned To | Triage Finance => AtulOpenbravo | |||||||||
| 2019-10-14 14:11 | hgbot | Checkin | ||||||||||
| 2019-10-14 14:11 | hgbot | Note Added: 0115065 | ||||||||||
| 2019-10-14 14:11 | hgbot | Status | new => resolved | |||||||||
| 2019-10-14 14:11 | hgbot | Resolution | open => fixed | |||||||||
| 2019-10-14 14:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/api-checks/rev/02db515fff90896e2bb7b3da14b20bdabcad9280 [^] | |||||||||
| 2019-10-14 15:25 | hgbot | Checkin | ||||||||||
| 2019-10-14 15:25 | hgbot | Note Added: 0115071 | ||||||||||
| 2019-10-17 08:30 | aferraz | Review Assigned To | dmitry_mezentsev => aferraz | |||||||||
| 2019-10-17 08:30 | aferraz | Note Added: 0115132 | ||||||||||
| 2019-10-17 08:30 | aferraz | Status | resolved => closed | |||||||||
| 2019-10-17 08:30 | aferraz | Fixed in Version | => 3.0PR20Q1 | |||||||||
| 2020-01-30 14:41 | AtulOpenbravo | Issue cloned | 0043070 | |||||||||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||