Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041407Retail ModulesWeb POSpublic2019-07-19 13:342019-08-16 07:37
Reporterasiermartirena 
Assigned Toasiermartirena 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041407: Changes to make the stock queries responses more extensible
DescriptionCurrently, there are some points in the Web POS in which stock queries are done. It is possible to do the queries because one or more processes needs the stock, and it is developed to do a single query for each line (instead of multiple queries for a single line).
Also, it is possible to manage the response to be able to continue with the action or to show a popup to ask for confirmation. But this is not as extensible as it should. It must be possible to modify the response of a stock action from an external module, without changing the response of the other actions. In order to do it, the different responses must be stored to have a final action, instead of storing an only response with the final action.
Steps To ReproduceTry to pay discontinued tickets.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-19 13:34asiermartirenaNew Issue
2019-07-19 13:34asiermartirenaAssigned To => asiermartirena
2019-07-19 13:34asiermartirenaTriggers an Emergency Pack => No
2019-07-23 12:51hgbotCheckin
2019-07-23 12:51hgbotNote Added: 0113590
2019-07-23 12:51hgbotStatusnew => resolved
2019-07-23 12:51hgbotResolutionopen => fixed
2019-07-23 12:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5605717ef603fdd594cba1c1fd7e80590dbc27d [^]
2019-07-26 10:55hgbotCheckin
2019-07-26 10:55hgbotNote Added: 0113674
2019-08-02 10:26hgbotCheckin
2019-08-02 10:26hgbotNote Added: 0113776
2019-08-02 10:33hgbotCheckin
2019-08-02 10:33hgbotNote Added: 0113777
2019-08-06 13:15hgbotCheckin
2019-08-06 13:15hgbotNote Added: 0113842
2019-08-16 07:37marvintmReview Assigned To => marvintm
2019-08-16 07:37marvintmStatusresolved => closed
2019-08-16 07:37marvintmFixed in Version => RR19Q4

Notes
(0113590)
hgbot   
2019-07-23 12:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e5605717ef603fdd594cba1c1fd7e80590dbc27d
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Mon Jul 22 22:00:15 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e5605717ef603fdd594cba1c1fd7e80590dbc27d [^]

Fixed issue 41407: Changes to make the stock queries responses more extensible

Now it will be easier to manage the stock responses from external modules, without affecting to the possible response other stock check.
In addition, code performed to avoid duplicity.
Update the warehouseqty value received from the StoreDetailedStock.java class, to have the value as a numeric value, not as a string value.
The 'payOpenTicketsValidation' now instead of having a 'loading' scrim, it is used with an 'opaque' scrim. This allows to show different popup during the process to set the needed validations. It was not possible to do it with the 'loading' scrim.

---
M src-db/database/sourcedata/OBMOBC_PROCESS_DEFINITION.xml
M src/org/openbravo/retail/posterminal/stock/StoreDetailedStock.java
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalstockdiscontinued.js
M web/org.openbravo.retail.posterminal/js/utils/stockUtils.js
---
(0113674)
hgbot   
2019-07-26 10:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4dbf30053fc3d270ad346d4d1f436a78039b576e
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Thu Jul 25 09:23:09 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4dbf30053fc3d270ad346d4d1f436a78039b576e [^]

Related to issue 41407: Stored the processes that causes a stock query

Now it is easier to check, during the response, which were exactly the causes that caused the stock query, being easier to do the needed action during the response.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/utils/stockUtils.js
---
(0113776)
hgbot   
2019-08-02 10:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0a0a54bd0b7d88cfdd8672810eea2e7411715f16
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Aug 02 10:24:31 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a0a54bd0b7d88cfdd8672810eea2e7411715f16 [^]

Related to issue 41407: Added the stockActions property to the OBPOS_PreAddProductWithStock hook

---
M web/org.openbravo.retail.posterminal/js/utils/stockUtils.js
---
(0113777)
hgbot   
2019-08-02 10:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 291b3fea448a6da5fcc7099dd0cde2a76733016b
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Fri Aug 02 10:33:36 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/291b3fea448a6da5fcc7099dd0cde2a76733016b [^]

Related to issue 41407: Backed out changeset 0a0a54bd0b7d

The changeset 0a0a54bd0b7d was pushed by error.

---
M web/org.openbravo.retail.posterminal/js/utils/stockUtils.js
---
(0113842)
hgbot   
2019-08-06 13:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 71ace13665e29b3da4b44bff6edf6646713de8cd
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Mon Aug 05 14:15:34 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/71ace13665e29b3da4b44bff6edf6646713de8cd [^]

Related to issue 41407: Updated also the return line flow

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---