Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0004140Openbravo ERPZ. Otherspublic2008-06-24 12:232014-02-17 12:01
plujan 
 
normalminorhave not tried
closedopen 
10XPsp2
2.40beta 
 
Core
No
0004140: AT240beta - [Clean up] - Remove unused smileys
On OpenbravoERP there are a lot of images that have not a purpose. By example, on

webapps\openbravo240beta\web\js\xinha\plugins\InsertSmiley\smileys

you will find more than 500 smileys that no one would use (see attach)
Clean-up, ReleaseCandidate
depends on feature request 0006041 closed iciordia Replace Xinha with Dojo 
jpg r240b1_FR_Smileys.JPG (39,244) 2008-06-24 12:23
https://issues.openbravo.com/file_download.php?file_id=125&type=bug
jpg
Issue History
2008-06-24 12:23plujanNew Issue
2008-06-24 12:23plujanAssigned To => cromero
2008-06-24 12:23plujansf_bug_id0 => 2001617
2008-06-24 12:23plujanFile Added: r240b1_FR_Smileys.JPG
2008-06-24 16:16pjuvaraTag Attached: ReleaseCandidate
2008-06-24 16:16pjuvaraStatusnew => scheduled
2008-06-24 16:16pjuvaraTarget Version => 2.50
2008-06-24 17:13pjuvaraTag Detached: ReleaseCandidate
2008-06-24 17:14pjuvaraStatusscheduled => closed
2008-06-24 17:14pjuvaraNote Added: 0007994
2008-06-24 17:14pjuvaraResolutionopen => no change required
2008-06-24 18:28pjuvaraTarget Version2.50 =>
2008-06-24 18:52plujanAssigned Tocromero => pjuvara
2008-06-24 18:52plujanStatusclosed => new
2008-06-24 18:52plujanResolutionno change required => open
2008-06-24 18:52plujanNote Added: 0007999
2008-06-27 15:22pjuvaraStatusnew => acknowledged
2008-06-27 15:23pjuvaraRelationship addedblocks 0004162
2008-10-28 12:38pjuvaraIssue Monitored: jordimas
2008-10-28 12:38pjuvaraNote Added: 0009791
2008-11-03 16:20pjuvaraNote Added: 0009945
2008-11-03 16:20pjuvaraAssigned Topjuvara => jordimas
2008-11-16 07:44pjuvaraAssigned Tojordimas => pjuvara
2008-11-16 14:51pjuvaraTag Attached: Clean-up
2008-11-16 14:51pjuvaraTag Attached: ReleaseCandidate
2008-11-16 14:52pjuvaraRelationship deletedblocks 0004162
2011-02-04 09:16jpabloaeAssigned Topjuvara => rmorley
2014-02-17 11:59alostaleRelationship addeddepends on 0006041
2014-02-17 12:00alostaleStatusacknowledged => scheduled
2014-02-17 12:00alostaleAssigned Tormorley =>
2014-02-17 12:00alostalefix_in_branch => pi
2014-02-17 12:01alostaleNote Added: 0064287
2014-02-17 12:01alostaleStatusscheduled => closed

Notes
(0007994)
pjuvara   
2008-06-24 17:14   
These smileys are distributed by Xinha, which is a library that Openbravo embeds.
It would therefore be incorrect for Openbravo to alter the library.
(0007999)
plujan   
2008-06-24 18:52   
From the Xinha webpage (a ticket opened for updating current license at http://xinha.webfactional.com/ticket/916 [^] ). Please not the part of "distributing with or without modifications":
#
#Xinha License (based on BSD license)
#Copyright (c) 2005-2007 xinha.org
#Copyright (c) 2002-2004 interactivetools.com, inc.
#Copyright (c) 2003-2004 dynarch.com
#All rights reserved.
#
#Redistribution and use in source and binary forms, with or without
#modification, are permitted provided that the following conditions are met:
#
#1) Redistributions of source code must retain the above copyright notice,
# this list of conditions and the following disclaimer.
#
#2) Redistributions in binary form must reproduce the above copyright notice,
# this list of conditions and the following disclaimer in the documentation
# and/or other materials provided with the distribution.
#
#3) Neither the names of the copyright owners nor the names of their
# contributors may be used to endorse or promote products derived from this
# software without specific prior written permission.

Also note that smileys are a plug-in ( as stated at http://xinha.webfactional.com/wiki/InsertSmiley [^] ) so I think there is not problem to remove this plug-in since in OpenbravoERP is not active (you cannot insert a smiley when editing help files)
(0009791)
pjuvara   
2008-10-28 12:38   
Reminder sent to: jordimas

What is the status of this feature request? Was it addressed in 2.50 as part of 4162 or did you decide not to implement it?

I would like to close it if possible either as fixed or as rejected (obviously with a justification).
(0009945)
pjuvara   
2008-11-03 16:20   
This feature request was not implemented in 2.50.
(0064287)
alostale   
2014-02-17 12:01   
Current plan is to completely remove xinha editor where all these smileys are located in