Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041397Retail ModulesDiscounts and Promotionspublic2019-07-18 13:362019-09-05 20:17
ReporterLeyre 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket10998
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041397: The negative total price should not be allowed in the POS Terminal when manual discounts are applied
DescriptionThe negative total price should not be allowed in the POS Terminal when manual discounts are applied
Steps To ReproduceBACKEND:
https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]

1. Configure two discounts:
 1.1 Discount Type: User Defined Amount
     Name: test1(look at the attached image)
     Discounted Amount: 10
     Currency: EUR
     Product: Insect repellent
 1.2 Discount Type: Variable Discount per Total Amount
     Name: test2(look at the attached image)
     Amount: 70
     Product: Insect repellent

WEB POS:
https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]

1. Add the product 'Insect repellent'.
2. Add the discount 'test1'.
3. Add the discount 'test2'.

Verify that the final price is negative -10.00 instead of 0.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040922pi closed ranjith_qualiantech_com Automatic absolute discounts can set line price to negative amount 
Attached Filespng discounts.png (85,153) 2019-07-18 13:36
https://issues.openbravo.com/file_download.php?file_id=13151&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-07-18 13:36LeyreNew Issue
2019-07-18 13:36LeyreAssigned To => Retail
2019-07-18 13:36LeyreFile Added: discounts.png
2019-07-18 13:36LeyreOBNetwork customer => Gold
2019-07-18 13:36LeyreSupport ticket => 10998
2019-07-18 13:36LeyreResolution time => 1565215200
2019-07-18 13:36LeyreTriggers an Emergency Pack => No
2019-07-25 10:54ngarciaRelationship addedrelated to 0040922
2019-08-01 21:07rqueraltaAssigned ToRetail => rqueralta
2019-08-01 21:08rqueraltaStatusnew => scheduled
2019-08-23 13:21hgbotCheckin
2019-08-23 13:21hgbotNote Added: 0114246
2019-08-23 13:21hgbotStatusscheduled => resolved
2019-08-23 13:21hgbotResolutionopen => fixed
2019-08-23 13:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59bbd8d6518a854cf8560b24ed56b10b1b9d974f [^]
2019-08-23 13:23hgbotCheckin
2019-08-23 13:23hgbotNote Added: 0114247
2019-08-23 13:23hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59bbd8d6518a854cf8560b24ed56b10b1b9d974f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/5efebd4c8fc0edf2dbf71873da1dd3689696c104 [^]
2019-09-02 11:21marvintmReview Assigned To => marvintm
2019-09-02 11:21marvintmStatusresolved => closed
2019-09-02 11:21marvintmFixed in Version => RR19Q4
2019-09-05 20:17hgbotCheckin
2019-09-05 20:17hgbotNote Added: 0114430

Notes
(0114246)
hgbot   
2019-08-23 13:21   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 59bbd8d6518a854cf8560b24ed56b10b1b9d974f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Thu Aug 22 14:02:39 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/59bbd8d6518a854cf8560b24ed56b10b1b9d974f [^]

Fixed issue 41397: The negative total price should not be allowed in the POS
Terminal when manual discounts are applied

- If ticket gross amount is lower than 0, gross amount is set to 0

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---
(0114247)
hgbot   
2019-08-23 13:23   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 5efebd4c8fc0edf2dbf71873da1dd3689696c104
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Aug 23 07:10:20 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/5efebd4c8fc0edf2dbf71873da1dd3689696c104 [^]

Fixed issue 41397: The negative total price should not be allowed in the POS
Terminal when manual discounts are applied

- If ticket gross amount is lower than 0, gross amount is set to 0

---
M web/org.openbravo.retail.discounts.bytotal/js/promotion-by-total-utils.js
---
(0114430)
hgbot   
2019-09-05 20:17   
Repository: tools/automation/pi-mobile
Changeset: a4d56a19d241244ed2fec8af7b334e5cbb8c7724
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Sep 05 14:16:02 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a4d56a19d241244ed2fec8af7b334e5cbb8c7724 [^]

Related to issue 41397: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41397_VerifyNoNegativeTotalPriceWithManualDiscounts.java
---