Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041390Openbravo ERP09. Financial managementpublic2019-07-18 06:542019-08-22 14:45
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041390: Apply HQL style guide to TransactionsDao
DescriptionApply HQL style guide to TransactionsDao
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
related to defect 00412343.0PR19Q4 closed collazoandy4 TransactionsDao.getCurrentlyClearedAmt is not using bind-param 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-18 06:54collazoandy4New Issue
2019-07-18 06:54collazoandy4Assigned To => collazoandy4
2019-07-18 06:54collazoandy4OBNetwork customer => No
2019-07-18 06:54collazoandy4Modules => Core
2019-07-18 06:54collazoandy4Triggers an Emergency Pack => No
2019-07-18 06:54collazoandy4Statusnew => scheduled
2019-07-18 13:49collazoandy4Relationship addedrelated to 0041287
2019-07-18 13:49collazoandy4Note Added: 0113516
2019-08-02 14:19SandrahuguetRelationship addedrelated to 0041234
2019-08-02 14:20hgbotCheckin
2019-08-02 14:20hgbotNote Added: 0113784
2019-08-02 14:20hgbotStatusscheduled => resolved
2019-08-02 14:20hgbotResolutionopen => fixed
2019-08-02 14:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c597d48cb07c66c10d913cdc43d4ba871d82d27b [^]
2019-08-02 14:20hgbotCheckin
2019-08-02 14:20hgbotNote Added: 0113786
2019-08-02 14:21SandrahuguetReview Assigned To => Sandrahuguet
2019-08-02 14:21SandrahuguetNote Added: 0113788
2019-08-02 14:21SandrahuguetStatusresolved => closed
2019-08-02 14:21SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114198
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114200

Notes
(0113516)
collazoandy4   
2019-07-18 13:49   
Test Plan
  Create a new Sales Invoice with 'Al contado' payment method and complete it and add a payment to it
  Go to Financial Account window and select Caja record
    Create a new Funds Transfer with the payment amount
    Select the transaccion created by the invoice and clic on Reconcile
      Select the two records and clic on Reconcilie
    Check the process ends with out errors
(0113784)
hgbot   
2019-08-02 14:20   
Repository: erp/devel/pi
Changeset: c597d48cb07c66c10d913cdc43d4ba871d82d27b
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Jul 17 23:48:45 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/c597d48cb07c66c10d913cdc43d4ba871d82d27b [^]

Fixes issue 41390: Apply HQL style guide to TransactionsDao

Applied the new HQL format

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
---
(0113786)
hgbot   
2019-08-02 14:20   
Repository: erp/devel/pi
Changeset: 2b63a20c27d70fd1cb2e31b531fc31bfd09a0e36
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Aug 02 14:17:58 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2b63a20c27d70fd1cb2e31b531fc31bfd09a0e36 [^]

related to issue 41390 not necessary toString()

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
---
(0113788)
Sandrahuguet   
2019-08-02 14:21   
code review + testing ok
(0114198)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114200)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test