0041383: [19Q3] [D&P per hour] Discount or promotion can no longer be correctly created and used

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0041383

Retail Modules

Discounts and Promotions

public

2019-07-17 16:41

2019-08-22 14:44

Reporter

inaki_garcia

Assigned To

guilleaer

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

Fixed in Version

RR19Q4

Merge Request Status

Review Assigned To

jorge-garcia

OBNetwork customer

Support ticket

Regression level

QA functional test

Regression date

2019-02-22

Regression introduced in release

RR18Q3

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/73c8bbf59361 [^]

Triggers an Emergency Pack

Summary

0041383: [19Q3] [D&P per hour] Discount or promotion can no longer be correctly created and used

Description

Due to the newly introduced "Discounts and Promotions per Hour" module extension, creating a discount or promotion in the usual workflow will lead to it not working. This is due to the newly added "Availability" section when creating a new discount or promotion, which has made it mandatory to have some of the the checkboxes checked in order to make the discount or promotion available for use when adding products to a ticket.

This issue is considered a regression, not because an error introduced in an existing project, but due to the disruption of the standard flow as a result of the introduction of this new functionality.

Steps To Reproduce

PRECONDITION: the "Discounts and Promotions per Hour" module must be installed alongside the standard "Discounts and Promotions" module

** Behaviour prior to the introduction of the module (19Q2 and earlier) **
-- Backend
0. Log in the ERP
1. Create a discount which isn't discretionary (p.e. "Price Adjustment" type) in the "Discounts and Promotions" window.
Fill all mandatory fields (highlighted in yellow), and add a Product by setting the "Included Products *" to "Only those defined"
and by creating a new record in the "Products" subtab

-- Frontend
0. Log in the Web POS as "vallblanca"
1. Add the product the discount has been created for
2. The discount is correctly added to the list item of the product

** Current behaviour **
- Execute steps 0 and 1 of Backend and Frontend
NOTICE that in step 2. of Frontend, the discount hasn't been correctly applied

-- Backend
2. Check the "All Week" checkbox in the availability section of the Discount, or check the current weekday and leave the Start/Ending Times blank

-- Frontend
- Execute steps 0 to 2 of Frontend
NOTICE that the discount is now correctly added

Proposed Solution

Additional Information