Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041373Openbravo ERP09. Financial managementpublic2019-07-17 06:512019-08-22 14:44
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041373: Apply HQL style guide to Reconciliation
DescriptionApply HQL style guide to Reconciliation
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-17 06:51collazoandy4New Issue
2019-07-17 06:51collazoandy4Assigned To => collazoandy4
2019-07-17 06:51collazoandy4OBNetwork customer => No
2019-07-17 06:51collazoandy4Modules => Core
2019-07-17 06:51collazoandy4Triggers an Emergency Pack => No
2019-07-17 06:51collazoandy4Statusnew => scheduled
2019-07-17 06:52collazoandy4Relationship addedrelated to 0041287
2019-07-18 06:41collazoandy4Note Added: 0113491
2019-07-18 16:25hgbotCheckin
2019-07-18 16:25hgbotNote Added: 0113525
2019-07-18 16:25hgbotStatusscheduled => resolved
2019-07-18 16:25hgbotResolutionopen => fixed
2019-07-18 16:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e6e23c5db460d6c75011824bd646028a350b9861 [^]
2019-07-18 16:26dmiguelezReview Assigned To => dmiguelez
2019-07-18 16:26dmiguelezNote Added: 0113527
2019-07-18 16:26dmiguelezStatusresolved => closed
2019-07-18 16:26dmiguelezFixed in Version => 3.0PR19Q4
2019-07-19 09:45hgbotCheckin
2019-07-19 09:45hgbotNote Added: 0113546
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114159
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114168

Notes
(0113491)
collazoandy4   
2019-07-18 06:41   
Test Plan
  Create a new Sales Invoice with 'Al contado' payment method and complete it and add a payment to it
  Go to Financial Account window and select Caja record
    Create a new Funds Transfer with the payment amount
    Select the transaccion created by the invoice and clic on Reconcile
      Select the two records and clic on Reconcilie
    Check the process ends with out errors
(0113525)
hgbot   
2019-07-18 16:25   
Repository: erp/devel/pi
Changeset: e6e23c5db460d6c75011824bd646028a350b9861
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 16:11:09 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e6e23c5db460d6c75011824bd646028a350b9861 [^]

Fixes issue 41373: Apply HQL style guide to Reconciliation

Applied the new HQL style in Reconciliation

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
---
(0113527)
dmiguelez   
2019-07-18 16:26   
Code Review + Testing Ok
(0113546)
hgbot   
2019-07-19 09:45   
Repository: erp/devel/pi
Changeset: 3816893e4737c469df63f3b89d725b56f1cf564c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 19 09:42:32 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3816893e4737c469df63f3b89d725b56f1cf564c [^]

Related to Issue 41373. Removed unnecessary .toString() calls.
If the variable is already a String it is not necessary to
call to the .toString() method.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/Reconciliation.java
---
(0114159)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114168)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test