Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041372Openbravo ERP09. Financial managementpublic2019-07-17 06:442019-08-22 14:44
Reportercollazoandy4 
Assigned ToTriage Omni OMS 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041372: Apply HQL style guide to AdvPaymentMngtDao
DescriptionApply HQL style guide to AdvPaymentMngtDao
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-17 06:44collazoandy4New Issue
2019-07-17 06:44collazoandy4Assigned To => Triage Finance
2019-07-17 06:44collazoandy4Modules => Core
2019-07-17 06:44collazoandy4Triggers an Emergency Pack => No
2019-07-17 06:52collazoandy4Relationship addedrelated to 0041287
2019-07-17 06:52collazoandy4Statusnew => scheduled
2019-07-18 06:40collazoandy4Note Added: 0113490
2019-07-18 17:20hgbotCheckin
2019-07-18 17:20hgbotNote Added: 0113531
2019-07-18 17:20hgbotStatusscheduled => resolved
2019-07-18 17:20hgbotResolutionopen => fixed
2019-07-18 17:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/42f5b8fbba599240a41d60d47d5cbf363cd2cdfc [^]
2019-07-18 17:21dmiguelezReview Assigned To => dmiguelez
2019-07-18 17:21dmiguelezNote Added: 0113534
2019-07-18 17:21dmiguelezStatusresolved => closed
2019-07-18 17:21dmiguelezFixed in Version => 3.0PR19Q4
2019-07-19 09:45hgbotCheckin
2019-07-19 09:45hgbotNote Added: 0113547
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114162
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114169

Notes
(0113490)
collazoandy4   
2019-07-18 06:40   
Test Plan
  Void a non paid invoice
  Go to Payment Proposal window and create a new record
    Clic on Select Expected Payments and select one record
    Clic on Generate Payment and check the process ends without error
(0113531)
hgbot   
2019-07-18 17:20   
Repository: erp/devel/pi
Changeset: 42f5b8fbba599240a41d60d47d5cbf363cd2cdfc
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 18 16:31:24 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/42f5b8fbba599240a41d60d47d5cbf363cd2cdfc [^]

Fixes issue 41372: Apply HQL style guide to AdvPaymentMngtDao

Applied the new HQL style in AdvPaymentMngtDao

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0113534)
dmiguelez   
2019-07-18 17:21   
Code Review + Testing OK
(0113547)
hgbot   
2019-07-19 09:45   
Repository: erp/devel/pi
Changeset: 98f6173cee75b697a561d8fc1fb6c202fe180a6e
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 19 09:45:00 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/98f6173cee75b697a561d8fc1fb6c202fe180a6e [^]

Related to Issue 41372. Removed unnecessary .toString() calls.
If the variable is already a String it is not necessary to
call to the .toString() method.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0114162)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114169)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test