Openbravo Issue Tracking System - Retail Modules
View Issue Details
0041370Retail ModulesWeb POSpublic2019-07-16 17:102019-08-02 08:36
asiermartirena 
ranjith_qualiantech_com 
highmajoralways
closedfixed 
5
 
RR19Q4 
marvintm
No
0041370: Problems with the 'Can/cannot be delivered' property
The button shown to set a value to the obposCanbedelivered property is not correctly shown/hidden.
In single selection, the button must be shown when prepayments are configured and if the line doesn't have any delivery.
In multi selection, in addition to the requirements commented before, all the lines must have exactly the same value in the property.

Also, when doing a 'Cancel and Replace', currently the property is being set to true for each line. The value must be set to true only for those lines that are already delivered. Any line without any delivery and that had the property set to false must maintain the value.
Load in the Web POS using the terminal OMNI-1.
Add two lines.
Select both lines and click on the 'Set as undeliverable' button.
Select the lines again --> The button must be shown with the 'Set as deliverable' value.

Synchronize the ticket setting one line to obposCanbedelivered = true and the other one as obposCanbedelivered = false and pay the prepayment.
Load the ticket again --> one line has been delivered
Do a Cancel and Replace of the ticket --> The line that was not delivered can be delivered now. It must maintain the set value.
Patch attached to the issue with the solution. The patch has been done for 19Q1, it must be adapted to PI.
No tags attached.
diff issue_41370.diff (2,657) 2019-07-18 18:30
https://issues.openbravo.com/file_download.php?file_id=13154&type=bug
patch 41370_PI.patch (2,872) 2019-07-22 05:13
https://issues.openbravo.com/file_download.php?file_id=13158&type=bug
Issue History
2019-07-16 17:10asiermartirenaNew Issue
2019-07-16 17:10asiermartirenaAssigned To => Retail
2019-07-16 17:10asiermartirenaResolution time => 1564437600
2019-07-16 17:10asiermartirenaTriggers an Emergency Pack => No
2019-07-16 17:11asiermartirenaFile Added: issue_41370.diff
2019-07-18 04:51rqueraltaAssigned ToRetail => rqueralta
2019-07-18 04:51rqueraltaStatusnew => scheduled
2019-07-18 18:29aaroncaleroFile Deleted: issue_41370.diff
2019-07-18 18:30aaroncaleroFile Added: issue_41370.diff
2019-07-18 18:30aaroncaleroNote Added: 0113537
2019-07-22 05:13rqueraltaFile Added: 41370_PI.patch
2019-07-24 13:43ranjith_qualiantech_comAssigned Torqueralta => ranjith_qualiantech_com
2019-07-30 14:41hgbotCheckin
2019-07-30 14:41hgbotNote Added: 0113712
2019-07-30 14:41hgbotStatusscheduled => resolved
2019-07-30 14:41hgbotResolutionopen => fixed
2019-07-30 14:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b28693fe486d71e1bd2ea35af6e998be34b46c0b [^]
2019-08-02 08:36marvintmReview Assigned To => marvintm
2019-08-02 08:36marvintmStatusresolved => closed
2019-08-02 08:36marvintmFixed in Version => RR19Q4

Notes
(0113537)
aaroncalero   
2019-07-18 18:30   
Re-uploaded the patch because there was a small typo in a function.
(0113712)
hgbot   
2019-07-30 14:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b28693fe486d71e1bd2ea35af6e998be34b46c0b
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jul 30 18:11:43 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b28693fe486d71e1bd2ea35af6e998be34b46c0b [^]

Fixed issue 41370 : Problems with the 'Can/cannot be delivered' property

* Adapt the behavior Set/Unset Delivery button in single selection or multi
selection

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---