Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041363Retail ModulesWeb POSpublic2019-07-15 18:172019-08-21 15:17
Reporterucarrion 
Assigned Toalekosmp86 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041363: 'Add associations' button for services allows adding associations to lines/documents that are currently being canceled
Description'Add associations' button for services allows adding associations to lines/documents that are currently being canceled
Steps To Reproduce-Configure an szenario to do cancel&replace
-Login and create a layaway adding two products related to the same service
-Add the related service to the order
-Layaway the order
-Open the order again and cancel&replace it
-Select the service line and select 'Add associations' button
-Check that the lines of the original order can be selected
Proposed SolutionThis button should check if the lines proposed are already canceled / currently being canceled
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-15 18:17ucarrionNew Issue
2019-07-15 18:17ucarrionAssigned To => Retail
2019-07-15 18:17ucarrionResolution time => 1564956000
2019-07-15 18:17ucarrionTriggers an Emergency Pack => No
2019-08-01 20:54alekosmp86Assigned ToRetail => alekosmp86
2019-08-12 15:20hgbotCheckin
2019-08-12 15:20hgbotNote Added: 0113952
2019-08-12 15:20hgbotStatusnew => resolved
2019-08-12 15:20hgbotResolutionopen => fixed
2019-08-12 15:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b316e67a6f552d467378c25e7b6d0429cf3c9f8d [^]
2019-08-14 10:58hgbotCheckin
2019-08-14 10:58hgbotNote Added: 0114011
2019-08-14 10:58marvintmReview Assigned To => marvintm
2019-08-14 10:58marvintmStatusresolved => closed
2019-08-14 10:58marvintmFixed in Version => RR19Q4
2019-08-14 12:15hgbotCheckin
2019-08-14 12:15hgbotNote Added: 0114013
2019-08-16 14:02xmirasNote Added: 0114040
2019-08-16 14:02xmirasStatusclosed => new
2019-08-16 14:02xmirasResolutionfixed => open
2019-08-16 14:02xmirasFixed in VersionRR19Q4 =>
2019-08-16 15:38hgbotCheckin
2019-08-16 15:38hgbotNote Added: 0114041
2019-08-16 15:39alekosmp86Statusnew => acknowledged
2019-08-16 15:39alekosmp86Statusacknowledged => scheduled
2019-08-16 15:39alekosmp86Statusscheduled => resolved
2019-08-16 15:39alekosmp86Resolutionopen => fixed
2019-08-19 11:55marvintmStatusresolved => closed
2019-08-19 11:55marvintmFixed in Version => RR19Q4
2019-08-21 15:17hgbotCheckin
2019-08-21 15:17hgbotNote Added: 0114111

Notes
(0113952)
hgbot   
2019-08-12 15:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b316e67a6f552d467378c25e7b6d0429cf3c9f8d
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Sun Aug 11 13:03:15 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b316e67a6f552d467378c25e7b6d0429cf3c9f8d [^]

Fixed issue 41363: 'Add Associations' for services excludes the lines of the order

---
M src/org/openbravo/retail/posterminal/AssociateOrderLines.java
M web/org.openbravo.retail.posterminal/js/components/modalassociatetickets.js
---
(0114011)
hgbot   
2019-08-14 10:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 092081b40821a92fc7104e5d5dcc328b6d80a061
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Wed Aug 14 10:57:44 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/092081b40821a92fc7104e5d5dcc328b6d80a061 [^]

Related to issue 41363. Canceledorder should be used instead of the orderId of the selected line.
If the orderId of the selected line is used, the flow works in the case the service line was created in the original ticket, but doesn't work if the service lin is created in the new, replacing ticket. If canceledorder is used, the flow works correctly in both cases.

---
M web/org.openbravo.retail.posterminal/js/components/modalassociatetickets.js
---
(0114013)
hgbot   
2019-08-14 12:15   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0f617d166113ea931a3847be23bb6f25d6c7e282
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Wed Aug 14 12:14:59 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0f617d166113ea931a3847be23bb6f25d6c7e282 [^]

Related to issue 41363. Apply formatter correctly

---
M web/org.openbravo.retail.posterminal/js/components/modalassociatetickets.js
---
(0114040)
xmiras   
2019-08-16 14:02   
I tested in livebuils and is still failing https://drive.google.com/file/d/11V2SQiiOFZSwpR11NnHbATQ5xbE0884d/view [^]
(0114041)
hgbot   
2019-08-16 15:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 148b83e1110d6f58123070bb7ccb5fc3646d5989
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Aug 16 09:36:58 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/148b83e1110d6f58123070bb7ccb5fc3646d5989 [^]

Related to issue 41363: Fixed condition when getting the id of the order whose
orderlines will be excluded from selection

---
M web/org.openbravo.retail.posterminal/js/components/modalassociatetickets.js
---
(0114111)
hgbot   
2019-08-21 15:17   
Repository: tools/automation/pi-mobile
Changeset: a649330a68009383cd44a42f7acb58be76cc5fe0
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Aug 20 16:54:48 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a649330a68009383cd44a42f7acb58be76cc5fe0 [^]

Related to issue 41363: added automated test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/I41363_VerifyNoOriginalTicketLinesInAddAssocOfCanclReplace.java
---