Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041352Openbravo ERPA. Platformpublic2019-07-15 11:272019-08-22 14:45
Reporterdmiguelez 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041352: Wrong validation error when internet connection is slow
DescriptionWhen the internet connection is slow, a wrong validation is fired and the cell is marked as red when the values are correct
Steps To Reproduce1.- Create a New Purchase Order
2.- Click the button "Create Lines"
3.- Add the columns "Aum" and "Aum Quantity"
4.- Open the Chrome dev tools and set the Internet connection to "3G fast"
5.- Enter a value in the "Aum Quantity" and later click in another row

Error: the cell is in red but the value is correct.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041087 closed collazoandy4 when the internet connection is slow the GetConvertedQtyActionHandler don't set the value in the correct cell 
Attached Files? 41087.mp4 (3,027,874) 2019-07-15 11:27
https://issues.openbravo.com/file_download.php?file_id=13129&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-15 11:27dmiguelezNew Issue
2019-07-15 11:27dmiguelezAssigned To => platform
2019-07-15 11:27dmiguelezFile Added: 41087.mp4
2019-07-15 11:27dmiguelezModules => Core
2019-07-15 11:27dmiguelezResolution time => 1562796000
2019-07-15 11:27dmiguelezTriggers an Emergency Pack => No
2019-07-15 11:27dmiguelezRelationship addedrelated to 0041087
2019-07-15 17:42AugustoMauchAssigned Toplatform => AugustoMauch
2019-07-17 18:19hgbotCheckin
2019-07-17 18:19hgbotNote Added: 0113485
2019-07-17 18:19hgbotStatusnew => resolved
2019-07-17 18:19hgbotResolutionopen => fixed
2019-07-17 18:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7d4eb3d7c838679542b1ef1729a369ba36620662 [^]
2019-07-17 18:20AugustoMauchReview Assigned To => alostale
2019-07-18 09:35hgbotCheckin
2019-07-18 09:35hgbotNote Added: 0113498
2019-07-18 09:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7d4eb3d7c838679542b1ef1729a369ba36620662 [^] => http://code.openbravo.com/erp/devel/pi/rev/d48c24a6a5cf35c03b838827ef3117b6169a9ae7 [^]
2019-07-19 10:41AugustoMauchStatusresolved => new
2019-07-19 10:41AugustoMauchResolutionfixed => open
2019-07-19 10:43alostaleResolution time1562796000 =>
2019-07-19 10:43alostaleSeveritymajor => minor
2019-07-22 17:33hgbotCheckin
2019-07-22 17:33hgbotNote Added: 0113576
2019-07-22 17:33hgbotStatusnew => resolved
2019-07-22 17:33hgbotResolutionopen => fixed
2019-07-22 17:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/d48c24a6a5cf35c03b838827ef3117b6169a9ae7 [^] => http://code.openbravo.com/erp/devel/pi/rev/f82044001bce30a8e7c08b36deecfb1dfbad8253 [^]
2019-07-26 08:38alostaleNote Added: 0113663
2019-07-26 08:38alostaleStatusresolved => closed
2019-07-26 08:38alostaleFixed in Version => 3.0PR19Q4
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114156
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114157
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114172

Notes
(0113485)
hgbot   
2019-07-17 18:19   
Repository: erp/devel/pi
Changeset: 7d4eb3d7c838679542b1ef1729a369ba36620662
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 17 18:18:51 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7d4eb3d7c838679542b1ef1729a369ba36620662 [^]

Fixes issue 41352: Runs validation after modifying value in non-editing row

In pick and execute grids, when a row other than the one that has the editGrid is programatically edited
( for instance using the setEditValue function), the validation should be run again. Otherwise the row would
not be revalidated, since validation is done when leaving the row that has the editGrid.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0113498)
hgbot   
2019-07-18 09:35   
Repository: erp/devel/pi
Changeset: d48c24a6a5cf35c03b838827ef3117b6169a9ae7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 18 09:35:04 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d48c24a6a5cf35c03b838827ef3117b6169a9ae7 [^]

Related with issue Fixes issue 41352: Backed out changeset 7d4eb3d7c838

The changeset [1] has been backed out because it is causing an error in CI [2]

[1] https://code.openbravo.com/erp/devel/pi/rev/7d4eb3d7c838679542b1ef1729a369ba36620662 [^]
[2] http://ci.openbravo.com/view/int/job/int-addpayment2-pgsql/531/ [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0113576)
hgbot   
2019-07-22 17:33   
Repository: erp/devel/pi
Changeset: f82044001bce30a8e7c08b36deecfb1dfbad8253
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jul 22 17:33:24 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f82044001bce30a8e7c08b36deecfb1dfbad8253 [^]

Fixes issue 41352: Validates row when it is modified programatically

The problem was that when a row was programatically modified using the setEditValue method, the
change was not validated unless it was done in the row that was currently being edited in the UI.

Now the change will be validated, but only if the row is selected.

A changes has also been done on ob-aprm-addPayment.js to deselected a row before updating it,
because otherwise it caused a validation error.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0113663)
alostale   
2019-07-26 08:38   
reviewed + tested
(0114156)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114157)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114172)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test