Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041337Retail ModulesWeb POSpublic2019-07-11 12:062019-07-15 12:20
Reporterkchoperena 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041337: The price modification popup is showing over the approval popup
DescriptionWhen a price modification is requested and needs approval, the price modification popup is showing over the approval popup. Because of that, the OB.MobileApp.view.openedPopup variable has the false value even though we have a popup on the screen.
Steps To Reproduce1.- Log into the back-end as 'The White Valley Group Admin'
2.- Go to preference window
3.- Create the preference:
  - Client: The White Valley Group
  - Organization: *
  - Active=Y
  - Property List = Y
  - Selected = Y
  - Property = Web POS action Change price
  - Value = Y
  - All visibility fields empty
4.- Create the preference:
  - Client: The White Valley Group
  - Organization: *
  - Active=Y
  - Property List = Y
  - Selected = Y
  - Property = Web POS set Price approval
  - Value = Y
  - Visibile at User = Openbravo
  - Rest of visibility fields empty
5.- Create the preference:
  - Client: The White Valley Group
  - Organization: *
  - Active=Y
  - Property List = Y
  - Selected = Y
  - Property = Web POS set Price approval
  - Value = N
  - All visibility fields empty
6.- Go to the 'User' window and set as supervisor 'Openbravo' to the user 'vallblanca'
7.- Go to the 'Product' window and check if the product 'Headlamp ultralight' have the flag 'Editable Price' checked
8.- Log into the Web pos.
9.- Add the product 'WVG/L0001 - Headlamp ultralight' to the receipt
10.- Change price to 10€
11.- Fill the approval information and click on 'Approve' button

EXPECTED RESULT:
The price modification popup is showing over the approval popup and the OB.MobileApp.view.openedPopup variable has an incorrect value.

Video: https://drive.google.com/file/d/1xX5BZSaORpmbMdIyv7k2V3oXgzjf0qmV/view [^]
Proposed SolutionLaunch correctly the price modification popup when the approval is being hidden
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue 41337 source mobilecore.patch (1,933) 2019-07-15 09:21
https://issues.openbravo.com/file_download.php?file_id=13126&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-11 12:06kchoperenaNew Issue
2019-07-11 12:06kchoperenaAssigned To => Retail
2019-07-11 12:06kchoperenaOBNetwork customer => Gold
2019-07-11 12:06kchoperenaResolution time => 1563400800
2019-07-11 12:06kchoperenaTriggers an Emergency Pack => No
2019-07-12 09:03ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-07-15 09:21ranjith_qualiantech_comFile Added: issue 41337 source mobilecore.patch
2019-07-15 09:21ranjith_qualiantech_comStatusnew => scheduled
2019-07-15 11:57hgbotCheckin
2019-07-15 11:57hgbotNote Added: 0113366
2019-07-15 11:57hgbotStatusscheduled => resolved
2019-07-15 11:57hgbotResolutionopen => fixed
2019-07-15 11:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4af6900a0d26017f272e19edd6fa58c892993c06 [^]
2019-07-15 12:20migueldejuanaReview Assigned To => migueldejuana
2019-07-15 12:20migueldejuanaNote Added: 0113367
2019-07-15 12:20migueldejuanaStatusresolved => closed

Notes
(0113366)
hgbot   
2019-07-15 11:57   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4af6900a0d26017f272e19edd6fa58c892993c06
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 15 15:05:30 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4af6900a0d26017f272e19edd6fa58c892993c06 [^]

Fixed issue 41337 : Approval popup should be closed before callback called.

* If another popup is opened from approved popup callback,
  approval popup should be closed first and then new popup should be opened

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---
(0113367)
migueldejuana   
2019-07-15 12:20   
Tested and reviewed