Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041334Openbravo ERPZ. Otherspublic2019-07-10 19:552019-07-26 09:41
ReporterAtulOpenbravo 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041334: API Change:Delete obsolete db functions that have been deprecated
DescriptionFollowing deprecated db functions could be safely removed with minor refactor at the places where they are used.

m_get_offer_price
m_get_offer_std_price

m_get_offers_price
** For removing this candidate below refactor could be safely implemented.
- C_CREATE_PINVOICE_FROM_OUTS (used v_priceActual directly as it was returned by db functions)
- C_GENERATEPOFROMPROJECT, C_GENERATESOFROMPROJECT, C_GENERATESOFROMPROJECTORDER, C_GENERATESOFROMPROJECTPHASE, C_PROJECT_GENERATE, MRP_PURCHASEORDER, M_COPY_PRODUCT_TEMPLATE, (used v_PriceStd directly returned as it was returned by db functions.)
- M_EXPLODEBOMNOTSTOCK (used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_unit_price, v_price_actual and M_BOM_PriceList(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID) for v_gross_price_list)
- M_INOUT_CREATEINVOICE (used v_PriceActual for v_PriceActual, v_LineNetAmt as v_PriceActual is directly returned by the db function)
- M_INVEXPLODEBOMNOTSTOCK (Used M_BOM_PriceStd(CUR_BOM.M_ProductBOM_ID, v_PriceList_Version_ID))
- M_REQUISITION_CREATEPO (used COALESCE(Cur_Lines.PRICEACTUAL, pp.PRICESTD))
- UpdatePricesAndAmounts.java (used M_BOM_PriceStd(:productID, plv.id))
- M_BOM_PRICESTD(CL.M_PRODUCT_ID, M_GET_PRICELIST_VERSION(?, TO_DATE(?)))
- ExpenseSOrder_data.xsql (Uses directly priceactual in insertCOrderline method)
- RequisitionToOrder_data.xsql (Uses directly priceactual in insertCOrderline method)
- GetPriceOffer_data.xsql (Uses directly priceStd in getOffersPriceCurrency method)

m_get_offers_std_price: To remove this candidate below refactor could be safely implemented

- CopyFromInvoiceData.getOffersStdPrice (uses only two parameters: priceStd & invoiceid)
- CopyFromOrderData.getOffersStdPrice (uses only two parameters: priceStd & orderid)
- GetPriceOffer_data.xsql (Uses directly priceStd in getOffersStdPriceCurrency method)
Steps To Reproduce-
Proposed Solution
Additional Information
TagsApproved
Relationships
blocks feature request 0040823 closed AtulOpenbravo Delete obsolete db functions that have been deprecated long time ago 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-10 19:55AtulOpenbravoNew Issue
2019-07-10 19:55AtulOpenbravoAssigned To => dmitry_mezentsev
2019-07-10 19:55AtulOpenbravoOBNetwork customer => No
2019-07-10 19:55AtulOpenbravoModules => Core
2019-07-10 19:55AtulOpenbravoTriggers an Emergency Pack => No
2019-07-10 19:56AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=19077#r19077
2019-07-10 20:01AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=19078#r19078
2019-07-11 17:08dmitry_mezentsevTag Attached: Approved
2019-07-11 17:08dmitry_mezentsevAssigned Todmitry_mezentsev => AtulOpenbravo
2019-07-16 14:16AtulOpenbravoRelationship addedblocks 0040823
2019-07-23 15:35vmromanosStatusnew => scheduled
2019-07-23 19:17AtulOpenbravoDescription Updatedbug_revision_view_page.php?rev_id=19185#r19185
2019-07-23 19:18AtulOpenbravoNote Added: 0113600
2019-07-24 17:09hgbotCheckin
2019-07-24 17:09hgbotNote Added: 0113624
2019-07-24 17:09hgbotStatusscheduled => resolved
2019-07-24 17:09hgbotResolutionopen => fixed
2019-07-24 17:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/f18c6a305e39936d64d07980ae8b5b8437d1d5cc [^]
2019-07-26 09:41vmromanosReview Assigned To => vmromanos
2019-07-26 09:41vmromanosNote Added: 0113669
2019-07-26 09:41vmromanosStatusresolved => closed
2019-07-26 09:41vmromanosFixed in Version => 3.0PR19Q4

Notes
(0113600)
AtulOpenbravo   
2019-07-23 19:18   
Skipped removal of below candidates as the Warehouse rules include the procedure name, which is retrieved by the M_GET_STOCK_PARAM that uses it to launch the rule (aka the procedure).

m_warehouse_default_rule
m_warehouse_default_rule_param

M_WAREHOUSE_DEFAULT_RULE_PARAM & M_WAREHOUSE_DEFAULT_RULE references removed from standard and sample referenceData.
(0113624)
hgbot   
2019-07-24 17:09   
Repository: erp/devel/api-checks
Changeset: f18c6a305e39936d64d07980ae8b5b8437d1d5cc
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Jul 24 20:35:16 2019 +0530
URL: http://code.openbravo.com/erp/devel/api-checks/rev/f18c6a305e39936d64d07980ae8b5b8437d1d5cc [^]

Fixes Issue 0041334: API Change:Delete obsolete db functions that have been
deprecated

** Remove deprecated db functions m_get_offer_price, m_get_offer_std_price,
m_get_offers_price, m_get_offers_std_price, m_warehouse_default_rule,
m_warehouse_default_rule_param
** Remove references of above function from rest of the db functions
** Method GetPriceOfferData.getOffersPriceCurrency is changed

---
M java/reference/java.japi.gz
M model/src-db/database/model/functions/C_CREATE_PINVOICE_FROM_OUTS.xml
M model/src-db/database/model/functions/C_GENERATEPOFROMPROJECT.xml
M model/src-db/database/model/functions/C_GENERATESOFROMPROJECT.xml
M model/src-db/database/model/functions/C_GENERATESOFROMPROJECTORDER.xml
M model/src-db/database/model/functions/C_GENERATESOFROMPROJECTPHASE.xml
M model/src-db/database/model/functions/C_PROJECT_GENERATE.xml
M model/src-db/database/model/functions/MRP_PURCHASEORDER.xml
M model/src-db/database/model/functions/M_COPY_PRODUCT_TEMPLATE.xml
M model/src-db/database/model/functions/M_EXPLODEBOMNOTSTOCK.xml
M model/src-db/database/model/functions/M_INOUT_CREATEINVOICE.xml
M model/src-db/database/model/functions/M_INVEXPLODEBOMNOTSTOCK.xml
M model/src-db/database/model/functions/M_REQUISITION_CREATEPO.xml
R model/src-db/database/model/functions/M_GET_OFFERS_PRICE.xml
R model/src-db/database/model/functions/M_GET_OFFERS_STD_PRICE.xml
R model/src-db/database/model/functions/M_GET_OFFER_PRICE.xml
R model/src-db/database/model/functions/M_GET_OFFER_STD_PRICE.xml
---
(0113669)
vmromanos   
2019-07-26 09:41   
CI passed successfully, although new version of mass invoicing module