Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041332Retail ModulesDiscounts by Payment Methodpublic2019-07-10 13:342019-08-16 07:30
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket10779
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041332: Discounts by Payment Method are not applied when paying a layaway
DescriptionDiscounts by Payment Method are not applied when paying a layaway
Steps To ReproduceIn the backend:
   Set as Active a valid 'Payment Method Discount' in Discounts and Promotions window'

In the POS:
   Create a new ticket
   Add a product
   Click on the total for paying it
   Select the payment method defined in the discount
   Check the discount by payment method is shown:
      Pay ... after ... discount for ... payment
   Done

   Create a new ticket
   Select Layaway this receipt menu option
   Add a product
   Click on the total for paying it
   Select the payment method defined in the discount
   Check the discount by payment method is shown:
      Pay ... after ... discount for ... payment
   Click on Layaway

   Open Receipt
   Select previously created layaway
   Click on the total for paying it
   Select the payment method defined in the discount
   Check the discount by payment method is not shown:
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034856 closed ranjith_qualiantech_com Issues in Payment Method discount calculation 
related to defect 0033511 closed ranjith_qualiantech_com Error When completing layaway from backend with payment method discount 
Attached Filesdiff 10779.diff (1,228) 2019-07-12 08:54
https://issues.openbravo.com/file_download.php?file_id=13114&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-10 13:34ngarciaNew Issue
2019-07-10 13:34ngarciaAssigned To => Retail
2019-07-10 13:34ngarciaOBNetwork customer => Gold
2019-07-10 13:34ngarciaSupport ticket => 10779
2019-07-10 13:34ngarciaTriggers an Emergency Pack => No
2019-07-10 13:35ngarciaRelationship addedrelated to 0034856
2019-07-10 13:42ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-07-10 13:42ranjith_qualiantech_comStatusnew => scheduled
2019-07-12 08:54ngarciaFile Added: 10779.diff
2019-07-12 08:54ngarciaNote Added: 0113321
2019-07-12 15:54matias-bernalIssue Monitored: matias-bernal
2019-07-15 13:20ranjith_qualiantech_comRelationship addedrelated to 0033511
2019-07-16 08:07hgbotCheckin
2019-07-16 08:07hgbotNote Added: 0113390
2019-07-16 13:05hgbotCheckin
2019-07-16 13:05hgbotNote Added: 0113402
2019-07-17 07:45ranjith_qualiantech_comStatusscheduled => resolved
2019-07-17 07:45ranjith_qualiantech_comResolutionopen => fixed
2019-08-16 07:30marvintmReview Assigned To => marvintm
2019-08-16 07:30marvintmStatusresolved => closed
2019-08-16 07:30marvintmFixed in Version => RR19Q4

Notes
(0113321)
ngarcia   
2019-07-12 08:54   
Attached the patch applied by the partner in their customer instance
(0113390)
hgbot   
2019-07-16 08:07   
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: b2dec661646844b6c0493406cc6936f361d3dab9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jul 16 11:36:58 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/b2dec661646844b6c0493406cc6936f361d3dab9 [^]

Related to issue 41332 : Payment method discounts should be applied for layaways

* When layaway is opened, lines cannot be modified.
  But adding payment method discount, line gross price will be updated and receipt taxes should be recaluclated

---
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0113402)
hgbot   
2019-07-16 13:05   
Repository: tools/automation/pi-mobile
Changeset: befc36bf0c9d660001d48ccab323a4899ed3ee68
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jul 16 16:35:26 2019 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/befc36bf0c9d660001d48ccab323a4899ed3ee68 [^]

Verifies issue 41332 : Modified automated test 'I33511_VerifyLayaway'

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bypaymentmethod/I33511_VerifyLayaway.java
---