Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041315Openbravo ERP07. Sales managementpublic2019-07-08 12:022019-08-22 14:44
Reporterinaki_garcia 
Assigned Tocollazoandy4 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelAutomated tests
Regression date2019-07-03
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/f831b0b71a5ec700751e645c9e6980001acd8c7b [^]
Triggers an Emergency PackNo
Summary0041315: [AUoM] Operative Quantity isn't correctly calculated when Creating Lines in Purchase Invoice from a Return To Vendor order
DescriptionWhen creating lines from a Return To Vendor order in the Purchase Invoice window, those that make use of Alternate Unit of Measure don't have their Operative Quantity
correctly calculated, in accordance to the Conversion Rate of the alternate unit as the assertion of the AUMRTVc010InvoiceAReturnToVendorShipment test expects it.

This issue has arised from thanks to qa-pi-aum jobs executing under the QA tab of CI, and with the mentioned test. More details of one of the latest execution showing the
issue can be found in the following link:
https://ci.openbravo.com/view/qa/job/qa-pi-aum-pgsql/485/ [^]
Steps To ReproduceAs group admin role:
   Set 'Enable UOM Management' preference to Y
   Log out and log in
   Add Liter unit to 'Cerveza Ale 0,5L' in Alternate UOM tab as Primary UOM
   Add a conversion of 2
   Create a Goods Receipt
   Add 10 Liters of 'Cerveza Ale 0,5L':
      Operative Quantity: 10
      Alternative UOM: Liter
      Ordered Quantity: 20
      Storage Bin: O01
      UOM: Unit
   Book it
   Go to Return To Vendor
   Open the Pick/Edit Lines popup to select the lines of the previously created Goods Receipt
   Check the quantities and other fields are shown as in the order line in the pop-up
   Set the "returned" field to 3, "returned UOM" to "Liter" and "return reason" to "Defective"
   Check the Alternative UOM is updated with Liter in the Return To Vendor line:
      Movement Quantity: 6
   Book it
   Go to Return to Vendor Shipment, and use the Pick/Edit Lines popup to create the lines from the Return to Vendor, and book it
   Go to Purchase Invoice window, and create a new record by importing the lines with the Return To Vendor.
   NOTICE that the Operative Quantity shows as "-6" when the value expected by the test is "-3"
   
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00413213.0PR19Q3 closed collazoandy4 [AUoM] Operative Quantity isn't correctly calculated when Creating Lines in Purchase Invoice from a Return To Vendor order 
depends on backport 00413273.0PR19Q1.2 closed collazoandy4 [AUoM] Operative Quantity isn't correctly calculated when Creating Lines in Purchase Invoice from a Return To Vendor order 
depends on backport 00413283.0PR19Q2.1 closed collazoandy4 [AUoM] Operative Quantity isn't correctly calculated when Creating Lines in Purchase Invoice from a Return To Vendor order 
caused by defect 0041174 closed collazoandy4 Alternative UOM is modified to UOM in Create Lines From processes of Invoice window if it is defined as Secondary 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-08 12:02inaki_garciaNew Issue
2019-07-08 12:02inaki_garciaAssigned To => Triage Finance
2019-07-08 12:02inaki_garciaModules => Core
2019-07-08 12:02inaki_garciaRegression level => Automated tests
2019-07-08 12:02inaki_garciaRegression date => 2019-07-03
2019-07-08 12:02inaki_garciaRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/f831b0b71a5ec700751e645c9e6980001acd8c7b [^]
2019-07-08 12:02inaki_garciaTriggers an Emergency Pack => No
2019-07-08 12:02inaki_garciaIssue generated from0041174
2019-07-08 12:02inaki_garciaRelationship addedcaused by 0041174
2019-07-08 12:44inaki_garciaDescription Updatedbug_revision_view_page.php?rev_id=19057#r19057
2019-07-08 12:44inaki_garciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19059#r19059
2019-07-08 16:32inaki_garciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19065#r19065
2019-07-08 16:37ngarciaIssue Monitored: ngarcia
2019-07-08 17:10SandrahuguetAssigned ToTriage Finance => collazoandy4
2019-07-08 17:14inaki_garciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19066#r19066
2019-07-08 21:35collazoandy4Statusnew => scheduled
2019-07-09 10:22SandrahuguetStatusscheduled => acknowledged
2019-07-09 10:22SandrahuguetStatusacknowledged => scheduled
2019-07-10 08:54SandrahuguetStatusscheduled => acknowledged
2019-07-10 08:54SandrahuguetStatusacknowledged => scheduled
2019-07-10 18:41SandrahuguetSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19075#r19075
2019-07-11 12:48aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19103#r19103
2019-07-11 12:50aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19104#r19104
2019-07-11 18:29collazoandy4Note Added: 0113294
2019-07-11 20:16hgbotCheckin
2019-07-11 20:16hgbotNote Added: 0113305
2019-07-11 20:16hgbotStatusscheduled => resolved
2019-07-11 20:16hgbotResolutionopen => fixed
2019-07-11 20:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9cb428280b30ca250597896a89ab563265e3696a [^]
2019-07-11 20:16hgbotCheckin
2019-07-11 20:16hgbotNote Added: 0113306
2019-07-11 20:19SandrahuguetReview Assigned To => Sandrahuguet
2019-07-11 20:19SandrahuguetNote Added: 0113316
2019-07-11 20:19SandrahuguetStatusresolved => closed
2019-07-11 20:19SandrahuguetFixed in Version => 3.0PR19Q4
2019-07-17 10:09hgbotCheckin
2019-07-17 10:09hgbotNote Added: 0113467
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114143
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114144

Notes
(0113294)
collazoandy4   
2019-07-11 18:29   
Test Plan
  As system admin role:
   Set 'Enable UOM Management' preference to Y
   Log out and log in
  As F&B group admin role:
   Add Liter unit to 'Cerveza Ale 0,5L' in Alternate UOM tab as Primary UOM
   Add a conversion of 2
   Create a Goods Receipt with 10 Liters of 'Cerveza Ale 0,5L':
      Operative Quantity: 10
      Alternative UOM: Liter
      Ordered Quantity: 20
      Storage Bin: O01
      UOM: Unit
   Book it
   Go to Return To Vendor and return 3 Liter of previous Goods Receipt and Book it
   Go to Return to Vendor Shipment, and use the Pick/Edit Lines popup to create the lines from the Return to Vendor, and book it
   Go to Purchase Invoice window, and create a new record by importing the lines with the Return To Vendor and check:
     Operative Quantity: -6
     Alternative UOM: Unit
     Invoice Quantity: -6
     UOM: Unit
   Remove the new invoice line
   Create a new record by importing the line from the Return to Vendor Shipment and check:
     Operative Quantity: -6
     Alternative UOM: Unit
     Invoice Quantity: -6
     UOM: Unit

Test Plan II
  Create a new Sales Order with 5 Liter of Cerveza Ale 0,5L
  Create a new Sales Invoice and import the previous order line and check:
     Operative Quantity: 5
     Alternative UOM: Liter
     Invoice Quantity: 10
     UOM: Unit
(0113305)
hgbot   
2019-07-11 20:16   
Repository: erp/devel/pi
Changeset: 9cb428280b30ca250597896a89ab563265e3696a
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 11 10:53:26 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/9cb428280b30ca250597896a89ab563265e3696a [^]

Fixes issue 41315: [AUoM] Operative Quantity isn't correctly calculated when
Creating Lines in Purchase Invoice from a Return To Vendor order

A wrong operative UOM was used to create the new invoiceline if the orderline is
related to a shipment, the quantity is calculated in the P&E and the UOM from the copied
line.

Now when a line is created from an orderline and is related to a not invoiced shipmentline
this shipmentline is used to create the new invoiceline, in case the orderline is a return
the return to vendor shipment line is used to create a new invoiceline

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/CreateLinesFromUtil.java
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateQuantitiesAndUOMs.java
---
(0113306)
hgbot   
2019-07-11 20:16   
Repository: erp/devel/pi
Changeset: 221767830742f8b992ed20c5c4b00071d7943525
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Jul 11 17:24:07 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/221767830742f8b992ed20c5c4b00071d7943525 [^]

related to issue 41315 code review changes

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/CreateLinesFromUtil.java
---
(0113316)
Sandrahuguet   
2019-07-11 20:19   
code review + testing ok
(0113467)
hgbot   
2019-07-17 10:09   
Repository: tools/automation/int
Changeset: 918ff9656d031728b0f1c5caa69a2ecb13a508f0
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 11 10:42:00 2019 -0400
URL: http://code.openbravo.com/tools/automation/int/rev/918ff9656d031728b0f1c5caa69a2ecb13a508f0 [^]

Related to issue 41315: Updated operative Quantity and UOM

The Operative Quantity and Operative UOM was updated to properly check the correct
values

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/aum/testsuites/returntovendor/AUMRTVc010InvoiceAReturnToVendorShipment.java
---
(0114143)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114144)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test