Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041306Openbravo ERP09. Financial managementpublic2019-07-06 01:262019-08-22 14:44
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041306: Apply HQL style guide to FIN_Utility
DescriptionApply HQL style guide to FIN_Utility
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-06 01:26collazoandy4New Issue
2019-07-06 01:26collazoandy4Assigned To => Triage Finance
2019-07-06 01:26collazoandy4OBNetwork customer => No
2019-07-06 01:26collazoandy4Modules => Core
2019-07-06 01:26collazoandy4Triggers an Emergency Pack => No
2019-07-06 01:26collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-06 01:26collazoandy4Statusnew => scheduled
2019-07-06 01:31collazoandy4Relationship addedrelated to 0041287
2019-07-13 14:43collazoandy4Note Added: 0113341
2019-07-16 18:22hgbotCheckin
2019-07-16 18:22hgbotNote Added: 0113449
2019-07-16 18:25dmiguelezNote Added: 0113455
2019-07-16 18:25dmiguelezStatusscheduled => resolved
2019-07-16 18:25dmiguelezFixed in Version => 3.0PR19Q4
2019-07-16 18:25dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/96f308eeb304 [^]
2019-07-16 18:25dmiguelezResolutionopen => fixed
2019-07-16 18:25dmiguelezReview Assigned To => dmiguelez
2019-07-16 18:25dmiguelezNote Added: 0113456
2019-07-16 18:25dmiguelezStatusresolved => closed
2019-07-19 09:45hgbotCheckin
2019-07-19 09:45hgbotNote Added: 0113545
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114152
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114167

Notes
(0113341)
collazoandy4   
2019-07-13 14:43   
Test Plan
  Go to Sales Invoice and create one record for Alimentos y Supermercados, S.A
    Create a new record in Lines tab:
      Product: Limonada 0,5L
      Invoiced Quantity: 10
    Complete the invoice
  Go to Payment In and create a new record for same BP
    Clic on Add Details and select previous invoice
    Clic on Reactivate and check the process ends without error
(0113449)
hgbot   
2019-07-16 18:22   
Repository: erp/devel/pi
Changeset: 96f308eeb30495e7c1cefea76f478991c8a334a8
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 16 16:47:48 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/96f308eeb30495e7c1cefea76f478991c8a334a8 [^]

iFixes issue 41306: Apply HQL style guide to FIN_Utility

Applied the new HQL style in FIN_Utility

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0113455)
dmiguelez   
2019-07-16 18:25   
Fixed by commit: https://code.openbravo.com/erp/devel/pi/rev/96f308eeb304 [^]
(0113456)
dmiguelez   
2019-07-16 18:25   
Code Review + Testing Ok
(0113545)
hgbot   
2019-07-19 09:45   
Repository: erp/devel/pi
Changeset: 3d6f741849bd42904d4b46bd9f4d59965e32cc24
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 19 09:41:22 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d6f741849bd42904d4b46bd9f4d59965e32cc24 [^]

Related to Issue 41306. Removed unnecessary .toString() calls.
If the variable is already a String it is not necessary to
call to the .toString() method.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0114152)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114167)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test