Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041302Openbravo ERP09. Financial managementpublic2019-07-06 01:152019-08-22 14:44
collazoandy4 
collazoandy4 
normalmajoralways
closedfixed 
5
 
3.0PR19Q3 
dmiguelez
Core
No
0041302: Apply HQL style guide to PaymentReportDao
Apply HQL style guide to PaymentReportDao
-
No tags attached.
related to design defect 0041287 acknowledged platform Tracking issue: Convert HQL to apply new style 
related to defect 00411993.0PR19Q4 closed collazoandy4 PaymentReportDao is not using bind-param 
Issue History
2019-07-06 01:15collazoandy4New Issue
2019-07-06 01:15collazoandy4Assigned To => collazoandy4
2019-07-06 01:15collazoandy4Modules => Core
2019-07-06 01:15collazoandy4Triggers an Emergency Pack => No
2019-07-06 01:17collazoandy4Statusnew => scheduled
2019-07-06 01:18collazoandy4Relationship addedrelated to 0041287
2019-07-08 21:41collazoandy4Note Added: 0113226
2019-07-11 15:11SandrahuguetRelationship addedrelated to 0041199
2019-07-16 16:40dmiguelezNote Added: 0113431
2019-07-16 16:40dmiguelezStatusscheduled => resolved
2019-07-16 16:40dmiguelezFixed in Version => 3.0PR19Q3
2019-07-16 16:40dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/eb6dbfe69fd7 [^]
2019-07-16 16:40dmiguelezResolutionopen => fixed
2019-07-16 16:40dmiguelezReview Assigned To => dmiguelez
2019-07-16 16:40dmiguelezNote Added: 0113432
2019-07-16 16:40dmiguelezStatusresolved => closed
2019-07-19 09:45hgbotCheckin
2019-07-19 09:45hgbotNote Added: 0113544
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114166

Notes
(0113226)
collazoandy4   
2019-07-08 21:41   
Test Plan
  Go to Payment Report window and export the report to excel and check the process ends without error
(0113431)
dmiguelez   
2019-07-16 16:40   
Fixed by commit: https://code.openbravo.com/erp/devel/pi/rev/eb6dbfe69fd7 [^]
(0113432)
dmiguelez   
2019-07-16 16:40   
Code Review + Testing Ok
(0113544)
hgbot   
2019-07-19 09:45   
Repository: erp/devel/pi
Changeset: 7ea164af68778b888f663d37ca4b0124aabbbc1f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 19 09:40:52 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7ea164af68778b888f663d37ca4b0124aabbbc1f [^]

Related to Issue 41302. Removed unnecessary .toString() calls.
If the variable is already a String it is not necessary to
call to the .toString() method.

---
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportDao.java
---
(0114166)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test