Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041301Retail ModulesGift cards and gift voucherspublic2019-07-05 13:402019-07-15 15:29
Reporterucarrion 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tojorge-garcia
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041301: A gift card can be reimbursed many times not taking into account it's available amount (gift card / certificate / credit notes)
DescriptionA gift card can be reimbursed many times not taking into account it's available amount.

This happens only when the selected payment method is part of a Payment Method Category.
Steps To ReproduceIn livebuilds - modules environment:
Login in backend.
Go to the POS Payment Method Category window and create a new record (Name: Cash PMC)
Go to the Touchpoint window, find the YS-11 record, go to the payment type tab and navigate to the Cash Payment Method (Touchpoint type window)
Configure the Payment Method Category to the one created earlier.

Login in Web POS
Create a credit note (i.e. create a negative ticket for the customer Carl Studson and return it using Credit Notes to generate it).
Go to cash management and try to reimburse it totally:
  *Click on Reimburse
  *Find the Credit Note
  *On the Details popup click on Apply
  *Leave the full amount to reimburse
  *On the Payments Selector popup, click on Cash PMC (the category created
earlier)
  *Select the Cash payment method
  => At the same time two popups are shown: The reimburse confirmation, and again the Payments Selector on the background (see attached screenshot).

Once the transaction is completed, check that another transaction can be done again by selecting the payment method.
Reimburse one more time it totally
+Check that 2 identic transactions have been recorded
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_054.png (87,998) 2019-07-09 17:42
https://issues.openbravo.com/file_download.php?file_id=13098&type=bug
png

diff posterminal.diff (830) 2019-07-15 11:37
https://issues.openbravo.com/file_download.php?file_id=13130&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-05 13:40ucarrionNew Issue
2019-07-05 13:40ucarrionAssigned To => Retail
2019-07-05 13:40ucarrionResolution time => 1562796000
2019-07-05 13:40ucarrionTriggers an Emergency Pack => No
2019-07-08 15:08rqueraltaAssigned ToRetail => rqueralta
2019-07-08 15:09rqueraltaStatusnew => scheduled
2019-07-09 17:41aaroncaleroDescription Updatedbug_revision_view_page.php?rev_id=19070#r19070
2019-07-09 17:41aaroncaleroSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=19072#r19072
2019-07-09 17:42aaroncaleroNote Added: 0113251
2019-07-09 17:42aaroncaleroFile Added: Selection_054.png
2019-07-12 05:23hgbotCheckin
2019-07-12 05:23hgbotNote Added: 0113318
2019-07-12 05:23hgbotStatusscheduled => resolved
2019-07-12 05:23hgbotResolutionopen => fixed
2019-07-12 05:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1367f30b9966160497328c0ae68e8c00aa8c4cf [^]
2019-07-15 10:30hgbotCheckin
2019-07-15 10:30hgbotNote Added: 0113363
2019-07-15 11:37migueldejuanaAssigned Torqueralta => migueldejuana
2019-07-15 11:37migueldejuanaStatusresolved => new
2019-07-15 11:37migueldejuanaResolutionfixed => open
2019-07-15 11:37migueldejuanaFile Added: posterminal.diff
2019-07-15 15:28hgbotCheckin
2019-07-15 15:28hgbotNote Added: 0113377
2019-07-15 15:28hgbotStatusnew => resolved
2019-07-15 15:28hgbotResolutionopen => fixed
2019-07-15 15:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1367f30b9966160497328c0ae68e8c00aa8c4cf [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42038c5d4050812709e0286ff8701816efe4873d [^]
2019-07-15 15:29jorge-garciaReview Assigned To => jorge-garcia
2019-07-15 15:29jorge-garciaNote Added: 0113378
2019-07-15 15:29jorge-garciaStatusresolved => closed
2019-07-15 15:29jorge-garciaFixed in Version => RR19Q4

Notes
(0113251)
aaroncalero   
2019-07-09 17:42   
Updated issue description and steps to reproduce the issue consistently
(0113318)
hgbot   
2019-07-12 05:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a1367f30b9966160497328c0ae68e8c00aa8c4cf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Jul 09 14:54:58 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a1367f30b9966160497328c0ae68e8c00aa8c4cf [^]

Fixed issue 41301: A gift card can be reimbursed many times not taking into
account it's available amount (gift card / certificate / credit notes)

- If selected payment have payment method category some popups still open, now
all these popups will be closed, to avoid do the same action more than once

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js
---
(0113363)
hgbot   
2019-07-15 10:30   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 386e5bd7a7cadd41bfe1d67a20b845e06353dc24
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jul 15 10:30:07 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/386e5bd7a7cadd41bfe1d67a20b845e06353dc24 [^]

-Related to issue 41301: A gift card can be reimbursed many times not taking into
account it's available amount (gift card / certificate / credit notes)

Do not clos popups of gitcard from posterminal
Backed out changeset a1367f30b996

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js
---
(0113377)
hgbot   
2019-07-15 15:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 42038c5d4050812709e0286ff8701816efe4873d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Jul 15 11:36:22 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/42038c5d4050812709e0286ff8701816efe4873d [^]

Fixed issue 0041301: A gift card can be reimbursed many times not taking into account it's available amount (gift card / certificate / credit notes)

- Mark selectItem before hiding the popup to avoid reopening select Payment popup

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js
---
(0113378)
jorge-garcia   
2019-07-15 15:29   
Code reviewed and tested