Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041293Openbravo ERPA. Platformpublic2019-07-05 10:302019-08-22 14:44
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041293: apply HQL style guide to ADTreeDatasourceService
DescriptionApply HQL style guide to ADTreeDatasourceService
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00412393.0PR19Q4 closed alostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
blocks design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-05 10:30alostaleNew Issue
2019-07-05 10:30alostaleAssigned To => platform
2019-07-05 10:30alostaleModules => Core
2019-07-05 10:30alostaleTriggers an Emergency Pack => No
2019-07-05 10:31alostaleReview Assigned To => AugustoMauch
2019-07-05 10:31alostaleAssigned Toplatform => alostale
2019-07-05 10:31alostaleRelationship addedblocks 0041287
2019-07-05 10:34hgbotCheckin
2019-07-05 10:34hgbotNote Added: 0113195
2019-07-05 10:34hgbotStatusnew => resolved
2019-07-05 10:34hgbotResolutionopen => fixed
2019-07-05 10:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/100f2a2dfc5e40138a339a73c703b36bd1e47cdb [^]
2019-07-09 08:47alostaleRelationship addedrelated to 0041239
2019-07-18 13:38AugustoMauchNote Added: 0113515
2019-07-18 13:38AugustoMauchStatusresolved => closed
2019-07-18 13:38AugustoMauchFixed in Version => 3.0PR19Q4
2019-08-22 14:44hudsonbotCheckin
2019-08-22 14:44hudsonbotNote Added: 0114136

Notes
(0113195)
hgbot   
2019-07-05 10:34   
Repository: erp/devel/pi
Changeset: 100f2a2dfc5e40138a339a73c703b36bd1e47cdb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 03 13:55:29 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/100f2a2dfc5e40138a339a73c703b36bd1e47cdb [^]

fixed bug 41293: HQL style in ADTreeDatasourceService

  Don't use StringBuilder for String concatenation
  Some other small changes

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
---
(0113515)
AugustoMauch   
2019-07-18 13:38   
Code reviewed and verified
(0114136)
hudsonbot   
2019-08-22 14:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test