Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041288Openbravo ERPA. Platformpublic2019-07-04 18:212019-08-22 14:45
Reportershuehner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041288: Apply new HQL Style to OBContext & EntityAccessChecker
DescriptionBoth files have several HQL with:
- non-constant parts:
  i.e. organization.calss.getName()
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default

OBContext.java: 10 cases
EntityAccessChecker: 3 cases
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 18:21shuehnerNew Issue
2019-07-04 18:21shuehnerAssigned To => platform
2019-07-04 18:21shuehnerModules => Core
2019-07-04 18:21shuehnerTriggers an Emergency Pack => No
2019-07-04 18:21shuehnerRelationship addedblocks 0041287
2019-07-04 18:27shuehnerTarget Version => 3.0PR19Q4
2019-07-29 11:32AugustoMauchAssigned Toplatform => cberner
2019-07-29 12:03cbernerStatusnew => scheduled
2019-08-01 11:31hgbotCheckin
2019-08-01 11:31hgbotNote Added: 0113752
2019-08-01 11:31hgbotStatusscheduled => resolved
2019-08-01 11:31hgbotResolutionopen => fixed
2019-08-01 11:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1b6d525eaf93f81e84defed8b82726205c133d6d [^]
2019-08-01 12:23AugustoMauchReview Assigned To => AugustoMauch
2019-08-01 12:23AugustoMauchNote Added: 0113753
2019-08-01 12:23AugustoMauchStatusresolved => closed
2019-08-01 12:23AugustoMauchFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114193

Notes
(0113752)
hgbot   
2019-08-01 11:31   
Repository: erp/devel/pi
Changeset: 1b6d525eaf93f81e84defed8b82726205c133d6d
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Tue Jul 30 16:15:20 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1b6d525eaf93f81e84defed8b82726205c133d6d [^]

fixes issue 41288: Apply HQL style guide to OBContext & EntityAccessChecker

---
M src/org/openbravo/dal/core/OBContext.java
M src/org/openbravo/dal/security/EntityAccessChecker.java
---
(0113753)
AugustoMauch   
2019-08-01 12:23   
Code reviewed and verified
(0114193)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test