Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041281Localization Pack: SpainAEAT 349public2019-07-04 13:362019-09-09 12:27
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041281: AEAT3492010ReportDao is not using bind-params
DescriptionMany functions in this class are not using bind-parameters.

Note when fixing please apply new HQL-style to every HQL in this file.
Note when fixing please also fix the getReadableClientsInClause,getReadableOrganizationsInClause deprecated warnings (same topic)

When fixing probably those 2 utility methods should be deleted as they only help to write unsafe code:
createINClauseForBaseOBObject, createINClauseForOrgs
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041515 closed collazoandy4 Localization Pack: Spain Apply HQL style guide to AEAT3492010ReportDao 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
causes defect 0043250 closed Mery Anelo Localization Pack: Spain Error en parametro AEAT3492010ReportDao 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 13:36shuehnerNew Issue
2019-07-04 13:36shuehnerAssigned To => Opentix-Test
2019-07-04 13:36shuehnerRelationship addedblocks 0038136
2019-07-26 08:20dmiguelezAssigned ToOpentix-Test => collazoandy4
2019-07-31 17:54collazoandy4Statusnew => scheduled
2019-07-31 17:57collazoandy4CategoryAEAT 349 => AEAT 390
2019-07-31 17:57collazoandy4CategoryAEAT 390 => AEAT 349
2019-08-01 21:12collazoandy4Note Added: 0113765
2019-08-07 00:00collazoandy4Note Added: 0113849
2019-09-02 16:34SandrahuguetRelationship addedrelated to 0041515
2019-09-09 12:24hgbotCheckin
2019-09-09 12:24hgbotNote Added: 0114450
2019-09-09 12:25hgbotCheckin
2019-09-09 12:25hgbotNote Added: 0114452
2019-09-09 12:25hgbotStatusscheduled => resolved
2019-09-09 12:25hgbotResolutionopen => fixed
2019-09-09 12:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/eda9256e384696c75e7ad8da8150d6d735d5b665 [^]
2019-09-09 12:25hgbotCheckin
2019-09-09 12:25hgbotNote Added: 0114453
2019-09-09 12:25hgbotCheckin
2019-09-09 12:25hgbotNote Added: 0114454
2019-09-09 12:27SandrahuguetReview Assigned To => Sandrahuguet
2019-09-09 12:27SandrahuguetNote Added: 0114455
2019-09-09 12:27SandrahuguetStatusresolved => closed
2020-02-27 11:06psanjuanRelationship addedcauses 0043250

Notes
(0113765)
collazoandy4   
2019-08-01 21:12   
Test Plan
  Go to Tax Report Launcher window and set
    Organization: F&B España, S.A
    Report: Modelo 349 Trimestral v 2010
    Accounting Schema: F&B España, S.A US/A/Euro
    Year: 2018
    Period: Jan-18 - Mar-18
    Clic on Input Parameter button
    Clic on Generate Electronic File button and check the message
    'Fichero no generado. No se han detectado en el sistema transacciones correspondientes al modelo 349 para el periodo seleccionado.' is shown
  Go to Purchase Invoice and create a new record:
    BP: Bebidas Alegres, S.L.
    Accounting Date: 01-01-2018
    Invoice Date: 01-01-2018
    Create a new record in Lines tab:
      Product: Cerveza Ale 0,5L
      Tax: Adquisiciones intracomunitarias Bienes Inversión 18%
    Complete and Post the invoice
  Go to Sales Invoice and create a new record:
    BP: Alimentos y Supermercados, S.A
    Accounting Date: 01-01-2018
    Invoice Date: 01-01-2018
    Create a new record in Lines tab:
      Product: Agua sin Gas 1L
      Tax: Servicios prestados UE (%N=>0%)
    Complete and Post the invoice
  Go to Tax Report Launcher window and set
    Organization: F&B España, S.A
    Report: Modelo 349 Trimestral v 2010
    Accounting Schema: F&B España, S.A US/A/Euro
    Year: 2018
    Period: Jan-18 - Mar-18
    Clic on Input Parameter button
    Fill out the Persona and Teléfono fields
    Clic on Generate Electronic File button and check the process ends without errors
(0113849)
collazoandy4   
2019-08-07 00:00   
Test Plan II
  Go to Tax Report Launcher window and set
    Organization: F&B España, S.A
    Report: Modelo 349 Anual
    Accounting Schema: F&B España, S.A US/A/Euro
    Year: 2018
    Period: Anually
    Clic on Input Parameter button
    Clic on Generate Electronic File button and check the message
    'Fichero no generado. No se han detectado en el sistema transacciones correspondientes al modelo 349 para el periodo seleccionado.' is shown
  Go to Purchase Invoice and create a new record:
    BP: Bebidas Alegres, S.L.
    Accounting Date: 01-01-2018
    Invoice Date: 01-01-2018
    Create a new record in Lines tab:
      Product: Cerveza Ale 0,5L
      Tax: Adquisiciones intracomunitarias 7%
    Complete and Post the invoice
  Go to Sales Invoice and create a new record:
    BP: Alimentos y Supermercados, S.A
    Accounting Date: 01-01-2018
    Invoice Date: 01-01-2018
    Create a new record in Lines tab:
      Product: Agua sin Gas 1L
      Tax: Entregas intracomunitarias (%N=>0%)
    Complete and Post the invoice
  Go to Tax Report Launcher window and set
    Organization: F&B España, S.A
    Report: Modelo 349 Anual
    Accounting Schema: F&B España, S.A US/A/Euro
    Year: 2018
    Period: Anually
    Clic on Input Parameter button
    Fill out the Persona and Teléfono fields
    Clic on Generate Electronic File button and check the process ends without errors
(0114450)
hgbot   
2019-09-09 12:24   
Repository: erp/pmods/org.openbravo.module.aeat349.es
Changeset: 2263c484a5c1e92b01bc82b353fae08a20d130f4
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Aug 06 13:32:53 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/2263c484a5c1e92b01bc82b353fae08a20d130f4 [^]

Related to issue 41281: Set new eclipse build int format

---
M src/org/openbravo/module/aeat349/es/AEAT349ReportDao.java
---
(0114452)
hgbot   
2019-09-09 12:25   
Repository: erp/pmods/org.openbravo.module.aeat349.es
Changeset: eda9256e384696c75e7ad8da8150d6d735d5b665
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Aug 01 15:08:02 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/eda9256e384696c75e7ad8da8150d6d735d5b665 [^]

Fixes issue 41281: AEAT3492010ReportDao is not using bind-params

Added missing bind-parameters

---
M src/org/openbravo/module/aeat349/es/AEAT3492010ReportDao.java
M src/org/openbravo/module/aeat349/es/AEAT349ReportDao.java
---
(0114453)
hgbot   
2019-09-09 12:25   
Repository: erp/pmods/org.openbravo.module.aeat349.es
Changeset: 98fa4c69e0fcfc545a53ef82bd7ac87465dc8abc
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Sep 03 17:29:40 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/98fa4c69e0fcfc545a53ef82bd7ac87465dc8abc [^]

Related to issue 41281:An UnbalancedAdminModeCall Exception was thrown if the
collections are empty

---
M src/org/openbravo/module/aeat349/es/AEAT3492010ReportDao.java
---
(0114454)
hgbot   
2019-09-09 12:25   
Repository: erp/pmods/org.openbravo.module.aeat349.es
Changeset: 68892a8ca7e0fb1e46e8d8b899464e9a4ff0b293
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Sep 09 12:24:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/68892a8ca7e0fb1e46e8d8b899464e9a4ff0b293 [^]

related to issue 41281 code review changes

---
M src/org/openbravo/module/aeat349/es/AEAT3492010ReportDao.java
M src/org/openbravo/module/aeat349/es/AEAT349ReportDao.java
---
(0114455)
Sandrahuguet   
2019-09-09 12:27   
code review + testing ok