Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041278Openbravo ERP04. Warehouse managementpublic2019-07-04 12:372019-08-30 20:01
Reportershuehner 
Assigned ToTriage Omni WMS 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041278: CostingBackground.doExecute is not using bind-params
DescriptionThis code is not using bind-params:
      where.append(" and ad_isorgincluded(o.id, '" + bundle.getContext().getOrganization()
          + "', '" + bundle.getContext().getClient() + "') <> -1 ");

When fixing please apply new HQL-style to every HQL in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041454 closed collazoandy4 Apply HQL style guide to CostingBackground 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 12:37shuehnerNew Issue
2019-07-04 12:37shuehnerAssigned To => Triage Finance
2019-07-04 12:37shuehnerOBNetwork customer => No
2019-07-04 12:37shuehnerModules => Core
2019-07-04 12:37shuehnerTriggers an Emergency Pack => No
2019-07-04 12:38shuehnerRelationship addedblocks 0038136
2019-07-04 12:38shuehnerTarget Version => 3.0PR19Q4
2019-07-25 16:24collazoandy4Statusnew => scheduled
2019-07-26 15:38collazoandy4Note Added: 0113682
2019-08-29 14:03SandrahuguetRelationship addedrelated to 0041454
2019-08-29 14:34hgbotCheckin
2019-08-29 14:34hgbotNote Added: 0114331
2019-08-29 14:34hgbotStatusscheduled => resolved
2019-08-29 14:34hgbotResolutionopen => fixed
2019-08-29 14:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5fa7cd513ec48023340d67453712da3935d510ea [^]
2019-08-29 14:35SandrahuguetReview Assigned To => Sandrahuguet
2019-08-29 14:35SandrahuguetNote Added: 0114333
2019-08-29 14:35SandrahuguetStatusresolved => closed
2019-08-29 14:35SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-30 20:01hudsonbotCheckin
2019-08-30 20:01hudsonbotNote Added: 0114348

Notes
(0113682)
collazoandy4   
2019-07-26 15:38   
Test Plan
  Create a new Goods Shipment with Cerveza Ale 0,5L product.
  Run the Costing Background Process and check the transaccion in Product tab have a cost calculated
(0114331)
hgbot   
2019-08-29 14:34   
Repository: erp/devel/pi
Changeset: 5fa7cd513ec48023340d67453712da3935d510ea
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 25 17:04:10 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/5fa7cd513ec48023340d67453712da3935d510ea [^]

Fixes issue 41278: CostingBackground.doExecute is not using bind-params

Added missing bind-parameters

---
M src/org/openbravo/costing/CostingBackground.java
---
(0114333)
Sandrahuguet   
2019-08-29 14:35   
code review + testing ok
(0114348)
hudsonbot   
2019-08-30 20:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/981eeb35474e [^]
Maturity status: Test