Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041274Retail ModulesWeb POSpublic2019-07-04 12:272019-07-12 15:12
Reportershuehner 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q4Fixed in VersionRR19Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041274: PaidReceipts.checkOrderInErrorEntry is not using bind-params
DescriptionThat function is not using bind-params in the orIds + jsoninfo contains construction here:
        orBuilder.append(" imp.jsonInfo like '%" + id + "%' ");

...

          + "and (" + orIds + ")";

When fixing please apply new HQL-style to every HQL in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0041275RR19Q3 closed gorka_gil Retail Modules PaidReceipts.checkOrderInErrorEntry is not using bind-params 
depends on backport 0041276RR19Q2.1 closed gorka_gil Retail Modules PaidReceipts.checkOrderInErrorEntry is not using bind-params 
depends on backport 0041277RR19Q1.2 closed gorka_gil Retail Modules PaidReceipts.checkOrderInErrorEntry is not using bind-params 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-04 12:27shuehnerNew Issue
2019-07-04 12:27shuehnerAssigned To => Retail
2019-07-04 12:27shuehnerOBNetwork customer => No
2019-07-04 12:27shuehnerTriggers an Emergency Pack => No
2019-07-04 12:27shuehnerRelationship addedblocks 0038136
2019-07-04 12:36shuehnerStatusnew => scheduled
2019-07-08 17:43gorka_gilAssigned ToRetail => gorka_gil
2019-07-12 12:42hgbotCheckin
2019-07-12 12:42hgbotNote Added: 0113327
2019-07-12 12:42hgbotStatusscheduled => resolved
2019-07-12 12:42hgbotResolutionopen => fixed
2019-07-12 12:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f9a275ce6e68650c51c9f223c33cf946420cabc8 [^]
2019-07-12 15:12guilleaerReview Assigned To => guilleaer
2019-07-12 15:12guilleaerStatusresolved => closed
2019-07-12 15:12guilleaerFixed in Version => RR19Q4

Notes
(0113327)
hgbot   
2019-07-12 12:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f9a275ce6e68650c51c9f223c33cf946420cabc8
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Jul 08 14:57:21 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f9a275ce6e68650c51c9f223c33cf946420cabc8 [^]

Fixes issue 41274: use bind-params in PaidReceipts.checkOrderInErrorEntry

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---