Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041265Retail ModulesGift cards and gift voucherspublic2019-07-03 18:012019-07-10 19:18
Reportermarvintm 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041265: Consume Gift Card in case of not consumed in an error request
DescriptionWe can consume Gift Certificate/Gift Card/Voucher/Credit Note but the request can fail without knowing if the comsumption is done or not. Check in OrderLoader if it is done or not and do it if needed.
Steps To Reproducen/a
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate design defect 0039440 closed migueldejuana A Credit note is closed without any sales order associated. 
related to design defect 0041326 new Retail Consume Gift Voucher in case of not being consumed in the request (due to an error) 
Attached Filesdiff 18Q3.diff (16,447) 2019-07-10 17:21
https://issues.openbravo.com/file_download.php?file_id=13099&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 18:01marvintmNew Issue
2019-07-03 18:01marvintmAssigned To => migueldejuana
2019-07-03 18:01marvintmTriggers an Emergency Pack => No
2019-07-03 18:02marvintmRelationship addedhas duplicate 0039440
2019-07-04 08:13rafarodaIssue Monitored: rafaroda
2019-07-09 18:14hgbotCheckin
2019-07-09 18:14hgbotNote Added: 0113252
2019-07-09 18:14hgbotStatusnew => resolved
2019-07-09 18:14hgbotResolutionopen => fixed
2019-07-09 18:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/49203ce8c04adec93ad8d831f17f631c02c96415 [^]
2019-07-09 18:17migueldejuanaRelationship addedrelated to 0041326
2019-07-10 17:21migueldejuanaFile Added: 18Q3.diff
2019-07-10 19:18guilleaerReview Assigned To => guilleaer
2019-07-10 19:18guilleaerStatusresolved => closed
2019-07-10 19:18guilleaerFixed in Version => RR19Q4

Notes
(0113252)
hgbot   
2019-07-09 18:14   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 49203ce8c04adec93ad8d831f17f631c02c96415
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jul 09 18:10:49 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/49203ce8c04adec93ad8d831f17f631c02c96415 [^]

Fixed issue 0041265: Consume Gift Card in case of not consumed in an error request

- Covering Gift Certificate, Credit Note and Gift Card. Gift Voucher not covered
- If gift card consume fails, assume that it worked and it will be consumed in OrderLoaderhook

---
M src/org/openbravo/retail/giftcards/ConsumeGiftCardAmount.java
M src/org/openbravo/retail/giftcards/GiftCardModel.java
M src/org/openbravo/retail/giftcards/hooks/OrderLoaderHookGiftCard.java
M web/org.openbravo.retail.giftcards/js/hooks/PreReversePaymentHook.js
M web/org.openbravo.retail.giftcards/js/hooks/preaddpaymenthook.js
M web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
---