Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041263Openbravo ERP09. Financial managementpublic2019-07-02 15:582019-07-16 18:22
Reportershuehner 
Assigned ToTriage Omni OMS 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q1.3Fixed in Version3.0PR19Q1.3 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041263: FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params
DescriptionThis code is not using bind-params:

a.) major isPeriodOpen (i.e. call via Reconciliation.java)
b.) isReversePayment,getOrderedPaymentDetailList

When fixing please apply new HQL-Style to all 7 cases in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00412383.0PR19Q4 closed collazoandy4 FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 17:01shuehnerTypedefect => backport
2019-07-03 17:01shuehnerTarget Version => 3.0PR19Q1.2
2019-07-09 18:19shuehnerTarget Version3.0PR19Q1.2 => 3.0PR19Q1.3
2019-07-16 18:21hgbotCheckin
2019-07-16 18:21hgbotNote Added: 0113446
2019-07-16 18:21hgbotStatusscheduled => resolved
2019-07-16 18:21hgbotResolutionopen => fixed
2019-07-16 18:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/6c325c672b683dd3f1a986b72493260bb9fc27b3 [^]
2019-07-16 18:22dmiguelezReview Assigned To => dmiguelez
2019-07-16 18:22dmiguelezNote Added: 0113451
2019-07-16 18:22dmiguelezStatusresolved => closed
2019-07-16 18:22dmiguelezFixed in Version => 3.0PR19Q1.3

Notes
(0113446)
hgbot   
2019-07-16 18:21   
Repository: erp/backports/3.0PR19Q1.3
Changeset: 6c325c672b683dd3f1a986b72493260bb9fc27b3
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 16 18:17:53 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.3/rev/6c325c672b683dd3f1a986b72493260bb9fc27b3 [^]

Fixes issue 41263: FIN_Utility is not using bind-params

The isPeriodOpen, isReversePayment and getOrderedPaymentDetailList methods was
updated with bind-params

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0113451)
dmiguelez   
2019-07-16 18:22   
Code Review + Testing ok