Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041262Openbravo ERP09. Financial managementpublic2019-07-02 15:582019-08-01 08:40
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q2.1Fixed in Version3.0PR19Q2.1 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041262: FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params
DescriptionThis code is not using bind-params:

a.) major isPeriodOpen (i.e. call via Reconciliation.java)
b.) isReversePayment,getOrderedPaymentDetailList

When fixing please apply new HQL-Style to all 7 cases in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00412383.0PR19Q4 closed collazoandy4 FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 17:01shuehnerTypedefect => backport
2019-07-03 17:01shuehnerTarget Version => 3.0PR19Q2.1
2019-07-16 18:21hgbotCheckin
2019-07-16 18:21hgbotNote Added: 0113447
2019-07-16 18:21hgbotStatusscheduled => resolved
2019-07-16 18:21hgbotResolutionopen => fixed
2019-07-16 18:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/3f2d9730cf01781f5e8c71cecc6f4e0c24367d87 [^]
2019-07-16 18:22dmiguelezReview Assigned To => dmiguelez
2019-07-16 18:22dmiguelezNote Added: 0113452
2019-07-16 18:22dmiguelezStatusresolved => closed
2019-07-16 18:22dmiguelezFixed in Version => 3.0PR19Q2.1
2019-08-01 08:40SandrahuguetAssigned ToTriage Finance => collazoandy4

Notes
(0113447)
hgbot   
2019-07-16 18:21   
Repository: erp/backports/3.0PR19Q2.1
Changeset: 3f2d9730cf01781f5e8c71cecc6f4e0c24367d87
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 16 18:18:38 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.1/rev/3f2d9730cf01781f5e8c71cecc6f4e0c24367d87 [^]

Fixes issue 41262: FIN_Utility is not using bind-params

The isPeriodOpen, isReversePayment and getOrderedPaymentDetailList methods was
updated with bind-params

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0113452)
dmiguelez   
2019-07-16 18:22   
Code Review + Testing ok