Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041261Openbravo ERP09. Financial managementpublic2019-07-02 15:582019-07-16 18:24
shuehner 
Triage Finance 
normalmajorhave not tried
closedfixed 
5
 
3.0PR19Q33.0PR19Q3 
dmiguelez
Core
No
0041261: FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params
This code is not using bind-params:

a.) major isPeriodOpen (i.e. call via Reconciliation.java)
b.) isReversePayment,getOrderedPaymentDetailList

When fixing please apply new HQL-Style to all 7 cases in this file.
-
No tags attached.
blocks defect 00412383.0PR19Q4 closed collazoandy4 FIN_Utility.{isPeriodOpen,isReversePayment,getOrderedPaymentDetailList) are not using bind-params 
Issue History
2019-07-03 17:01shuehnerTypedefect => backport
2019-07-03 17:01shuehnerTarget Version => 3.0PR19Q3
2019-07-16 18:21hgbotCheckin
2019-07-16 18:21hgbotNote Added: 0113448
2019-07-16 18:24dmiguelezNote Added: 0113453
2019-07-16 18:24dmiguelezStatusscheduled => resolved
2019-07-16 18:24dmiguelezFixed in Version => 3.0PR19Q3
2019-07-16 18:24dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/backports/3.0PR19Q3/rev/77bfe8613a09 [^]
2019-07-16 18:24dmiguelezResolutionopen => fixed
2019-07-16 18:24dmiguelezReview Assigned To => dmiguelez
2019-07-16 18:24dmiguelezNote Added: 0113454
2019-07-16 18:24dmiguelezStatusresolved => closed

Notes
(0113448)
hgbot   
2019-07-16 18:21   
Repository: erp/backports/3.0PR19Q3
Changeset: 77bfe8613a092a30f9b8366c1fa1ee2a3ea3c68b
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Tue Jul 16 18:19:25 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/77bfe8613a092a30f9b8366c1fa1ee2a3ea3c68b [^]

iFixes issue 41261: FIN_Utility is not using bind-params

The isPeriodOpen, isReversePayment and getOrderedPaymentDetailList methods was
updated with bind-params

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0113453)
dmiguelez   
2019-07-16 18:24   
Fixed by commit: https://code.openbravo.com/erp/backports/3.0PR19Q3/rev/77bfe8613a09 [^]
(0113454)
dmiguelez   
2019-07-16 18:24   
Code Review + Testing Ok