Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041257Openbravo ERP01. General setuppublic2019-07-03 16:562019-08-29 13:37
shuehner 
collazoandy4 
normalminorhave not tried
closedfixed 
5
 
3.0PR19Q43.0PR19Q4 
Sandrahuguet
Core
No
0041257: InitialSetupUtility.{getCOAModules,getRDModules} are not using bind-parameters
Both method are not using bind-params for their strModules values.

Minor as caller filters via IsIDFilter.

When fixing please apply new HQL-style to all HQL in this file.
-
No tags attached.
related to defect 0041453 closed collazoandy4 Apply HQL style guide to InitialSetupUtility 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Issue History
2019-07-03 16:56shuehnerNew Issue
2019-07-03 16:56shuehnerAssigned To => Triage Finance
2019-07-03 16:56shuehnerModules => Core
2019-07-03 16:56shuehnerTriggers an Emergency Pack => No
2019-07-03 16:57shuehnerRelationship addedblocks 0038136
2019-07-04 12:16shuehnerTarget Version => 3.0PR19Q4
2019-07-24 19:45collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-26 15:37collazoandy4Note Added: 0113680
2019-07-26 15:38collazoandy4Statusnew => scheduled
2019-08-28 14:33SandrahuguetRelationship addedrelated to 0041453
2019-08-29 08:42hgbotCheckin
2019-08-29 08:42hgbotNote Added: 0114313
2019-08-29 08:42hgbotStatusscheduled => resolved
2019-08-29 08:42hgbotResolutionopen => fixed
2019-08-29 08:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d83c14dd9a313b961c6876fb3dea6237a3ee0b64 [^]
2019-08-29 08:42SandrahuguetReview Assigned To => Sandrahuguet
2019-08-29 08:42SandrahuguetNote Added: 0114314
2019-08-29 08:42SandrahuguetStatusresolved => closed
2019-08-29 08:42SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-29 13:37hudsonbotCheckin
2019-08-29 13:37hudsonbotNote Added: 0114329

Notes
(0113680)
collazoandy4   
2019-07-26 15:37   
Test Plan
  Go to Initial organization setup and create a new Legal with accounting Organization, set an accounting file and select all Reference data and clic on Ok button.
  Check the process ends without error and a new organization is created.
(0114313)
hgbot   
2019-08-29 08:42   
Repository: erp/devel/pi
Changeset: d83c14dd9a313b961c6876fb3dea6237a3ee0b64
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Jul 25 16:43:43 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/d83c14dd9a313b961c6876fb3dea6237a3ee0b64 [^]

Fixes issue 41257:InitialSetupUtility.{getCOAModules,getRDModules} are not using
bind-parameters

Added missing bind-parameters

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0114314)
Sandrahuguet   
2019-08-29 08:42   
code review + testing ok
(0114329)
hudsonbot   
2019-08-29 13:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/305eae82d1bd [^]
Maturity status: Test