Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041254Openbravo ERP08. Project and service managementpublic2019-07-03 16:522019-07-17 11:28
shuehner 
Triage Omni OMS 
normalmajorhave not tried
closedfixed 
5
 
3.0PR19Q33.0PR19Q3 
dmiguelez
Core
No
0041254: ReportProjectProfitabilityJR.noConversionToHours is not using bind-params
This code is not using bind-params:

    if (StringUtils.isNotEmpty(strOrg)) {
      hsqlScript.append(" and p." + Project.PROPERTY_ORGANIZATION + ".id in (" + strOrg + ")");
    }

When fixing please apply new HQL-style to every HQL in this file.
-
No tags attached.
blocks defect 00412533.0PR19Q4 closed AtulOpenbravo ReportProjectProfitabilityJR.noConversionToHours is not using bind-params 
Issue History
2019-07-03 16:53shuehnerTypedefect => backport
2019-07-03 16:53shuehnerTarget Version => 3.0PR19Q3
2019-07-17 11:26hgbotCheckin
2019-07-17 11:26hgbotNote Added: 0113472
2019-07-17 11:26hgbotStatusscheduled => resolved
2019-07-17 11:26hgbotResolutionopen => fixed
2019-07-17 11:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/eb79d76b3f7dba6b593397532aaf3ca976ec034d [^]
2019-07-17 11:28dmiguelezReview Assigned To => dmiguelez
2019-07-17 11:28dmiguelezNote Added: 0113476
2019-07-17 11:28dmiguelezStatusresolved => closed
2019-07-17 11:28dmiguelezFixed in Version => 3.0PR19Q3

Notes
(0113472)
hgbot   
2019-07-17 11:26   
Repository: erp/backports/3.0PR19Q3
Changeset: eb79d76b3f7dba6b593397532aaf3ca976ec034d
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Jul 15 18:17:44 2019 +0530
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/eb79d76b3f7dba6b593397532aaf3ca976ec034d [^]

Fixes Issue 41254: ReportProjectProfitabilityJR.noConversionToHours
is not using bind-params

Applied bind-params to organization ids in noConversionToHours
method. Organization ids are obtained from OrganizationStructureProvider

---
M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java
---
(0113476)
dmiguelez   
2019-07-17 11:28   
Code Review + Testing Ok