Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041252Openbravo ERP09. Financial managementpublic2019-07-03 16:482019-08-28 18:52
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041252: ReportGeneralLedgerJournal.getDocuments is not using bind-params
DescriptionThis function is not using bind-parameters for 2 Organization id's lists here:

      whereClause.append(DocumentType.PROPERTY_ORGANIZATION + ".id");
      whereClause.append(" in (" + Utility.getInStrSet(orgStrct) + ")");
      whereClause.append(" and ca." + AcctSchemaTable.PROPERTY_ORGANIZATION + ".id");
      whereClause.append(" in (" + Utility.getInStrSet(orgStrct) + ")");
      whereClause.append(" order by cd." + DocumentType.PROPERTY_DOCUMENTCATEGORY);

When fixing please apply new HQL-style to every HQL in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041452 closed collazoandy4 Apply HQL style guide to ReportGeneralLedgerJournal 
related to defect 0041711 closed collazoandy4 Subquery in getDocumentNo in ReportGeneralLedgerJournal is not using bind-params 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 16:48shuehnerNew Issue
2019-07-03 16:48shuehnerAssigned To => Triage Finance
2019-07-03 16:48shuehnerModules => Core
2019-07-03 16:48shuehnerTriggers an Emergency Pack => No
2019-07-03 16:49shuehnerRelationship addedblocks 0038136
2019-07-03 16:51shuehnerDescription Updatedbug_revision_view_page.php?rev_id=19027#r19027
2019-07-04 12:16shuehnerTarget Version => 3.0PR19Q4
2019-07-24 19:43collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-24 19:43collazoandy4Statusnew => scheduled
2019-07-24 23:10collazoandy4Note Added: 0113642
2019-08-28 10:20SandrahuguetRelationship addedrelated to 0041452
2019-08-28 13:56hgbotCheckin
2019-08-28 13:56hgbotNote Added: 0114296
2019-08-28 13:56hgbotStatusscheduled => resolved
2019-08-28 13:56hgbotResolutionopen => fixed
2019-08-28 13:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bfc248a387dd81a10b36ed9f06c7a524268760ce [^]
2019-08-28 13:58SandrahuguetReview Assigned To => Sandrahuguet
2019-08-28 13:58SandrahuguetNote Added: 0114297
2019-08-28 13:58SandrahuguetStatusresolved => closed
2019-08-28 13:58SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-28 14:01SandrahuguetRelationship addedrelated to 0041711
2019-08-28 18:52hudsonbotCheckin
2019-08-28 18:52hudsonbotNote Added: 0114306

Notes
(0113642)
collazoandy4   
2019-07-24 23:10   
Test Plan
  Go to Journal Entries Report and set:
    Organization: Region Norte
    General Ledger: F&B España
    From: 01-07-2018
    To: 24-07-2019
    From Account: (43000) Clientes (euros) a corto plazo
    To Account: (47700) Hacienda Pública IVA repercutido
    Document: AR Invoice
    DocumentNo: 1000259
  Clic on Search button and check the process ends without error
(0114296)
hgbot   
2019-08-28 13:56   
Repository: erp/devel/pi
Changeset: bfc248a387dd81a10b36ed9f06c7a524268760ce
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Jul 24 17:07:08 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/bfc248a387dd81a10b36ed9f06c7a524268760ce [^]

Fixes issue 41252:ReportGeneralLedgerJournal.getDocuments is not using
bind-params

Added missing bind-params

---
M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournal.java
---
(0114297)
Sandrahuguet   
2019-08-28 13:58   
code review + testing ok
(0114306)
hudsonbot   
2019-08-28 18:52   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/236aa85fbe33 [^]
Maturity status: Test