Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041250Openbravo ERP00. Application dictionarypublic2019-07-02 16:012019-07-09 11:05
Reportershuehner 
Assigned Toplatform 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q1.2Fixed in Version 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041250: ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params
DescriptionThose functions are not using bind-params.


when fixing please apply new HQL-style to all 3 HQL's in the file
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00412393.0PR19Q4 closed alostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 15:26alostaleTypedefect => backport
2019-07-03 15:26alostaleTarget Version => 3.0PR19Q1.2
2019-07-09 09:28hgbotCheckin
2019-07-09 09:28hgbotNote Added: 0113232
2019-07-09 09:28hgbotCheckin
2019-07-09 09:28hgbotNote Added: 0113233
2019-07-09 09:28hgbotStatusscheduled => resolved
2019-07-09 09:28hgbotResolutionopen => fixed
2019-07-09 09:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/2ac60bd8381037f1acb71a3316da04f6a64d8a95 [^]
2019-07-09 09:28alostaleReview Assigned Tocaristu => jarmendariz
2019-07-09 11:05jarmendarizNote Added: 0113238
2019-07-09 11:05jarmendarizStatusresolved => closed

Notes
(0113232)
hgbot   
2019-07-09 09:28   
Repository: erp/backports/3.0PR19Q1.2
Changeset: c4c7da2b74c57c79324c50a649b582c5e0299619
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 09 09:14:41 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/c4c7da2b74c57c79324c50a649b582c5e0299619 [^]

related to issue 41250: HQL style in ADTreeDatasourceService

  Don't use StringBuilder for String concatenation
  Some other small changes

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
---
(0113233)
hgbot   
2019-07-09 09:28   
Repository: erp/backports/3.0PR19Q1.2
Changeset: 2ac60bd8381037f1acb71a3316da04f6a64d8a95
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Jul 09 09:27:47 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q1.2/rev/2ac60bd8381037f1acb71a3316da04f6a64d8a95 [^]

fixed bug 41250: use bind parameters in ADTreeDatasourceService

  * Use parameter in query in getNodeChildrenQuery method where possible
  * Do not use deprecated OBDal.getReadableOrganizationsInClause method
  * Properly escape paremeter values in clasues coming from AD

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---
(0113238)
jarmendariz   
2019-07-09 11:05   
Reviewed