Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041248Openbravo ERP00. Application dictionarypublic2019-07-02 16:012019-07-05 18:36
Reportershuehner 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q3Fixed in Version3.0PR19Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041248: ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params
DescriptionThose functions are not using bind-params.


when fixing please apply new HQL-style to all 3 HQL's in the file
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00412393.0PR19Q4 closed alostale ADTreeDatasourceService.{getNodeChildenQuery,nodeHasChildren, nodeConformsToWhereClause) are not using bind-params 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-03 15:26alostaleTypedefect => backport
2019-07-03 15:26alostaleTarget Version => 3.0PR19Q3
2019-07-05 10:45hgbotCheckin
2019-07-05 10:45hgbotNote Added: 0113197
2019-07-05 10:45hgbotCheckin
2019-07-05 10:45hgbotNote Added: 0113198
2019-07-05 10:45hgbotStatusscheduled => resolved
2019-07-05 10:45hgbotResolutionopen => fixed
2019-07-05 10:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/aeeeea906d0428b90a560ebd1bbbbd1f33695672 [^]
2019-07-05 18:36caristuAssigned Toplatform => alostale
2019-07-05 18:36caristuNote Added: 0113207
2019-07-05 18:36caristuStatusresolved => closed
2019-07-05 18:36caristuFixed in Version => 3.0PR19Q3

Notes
(0113197)
hgbot   
2019-07-05 10:45   
Repository: erp/backports/3.0PR19Q3
Changeset: b7e512b8145c7dc229bc49e9a4ee3d7cc1bab81e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 03 13:55:29 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/b7e512b8145c7dc229bc49e9a4ee3d7cc1bab81e [^]

related to issue 41248: HQL style in ADTreeDatasourceService

  Don't use StringBuilder for String concatenation
  Some other small changes

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
---
(0113198)
hgbot   
2019-07-05 10:45   
Repository: erp/backports/3.0PR19Q3
Changeset: aeeeea906d0428b90a560ebd1bbbbd1f33695672
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Jul 03 15:38:10 2019 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3/rev/aeeeea906d0428b90a560ebd1bbbbd1f33695672 [^]

fixed bug 41248: use bind parameters in ADTreeDatasourceService

  * Use parameter in query in getNodeChildrenQuery method where possible
  * Do not use deprecated OBDal.getReadableOrganizationsInClause method
  * Properly escape paremeter values in clasues coming from AD

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/ADTreeDatasourceService.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java
---
(0113207)
caristu   
2019-07-05 18:36   
Reviewed