Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041245Openbravo ERP09. Financial managementpublic2019-07-02 16:282019-08-25 06:50
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041245: DocFINReconciliation.createFact is not using bind-params
DescriptionSeveral HQL in this method are not using bind-params.

When fixing please apply new HQL-style to all HQL in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041436 closed collazoandy4 Apply HQL style guide to DocFINReconciliation 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 16:28shuehnerNew Issue
2019-07-02 16:28shuehnerAssigned To => Triage Finance
2019-07-02 16:28shuehnerModules => Core
2019-07-02 16:28shuehnerTriggers an Emergency Pack => No
2019-07-02 16:28shuehnerRelationship addedblocks 0038136
2019-07-04 12:16shuehnerTarget Version => 3.0PR19Q4
2019-07-23 16:17collazoandy4Statusnew => scheduled
2019-07-23 16:17collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-24 19:41collazoandy4Note Added: 0113631
2019-08-22 14:13SandrahuguetRelationship addedrelated to 0041436
2019-08-22 14:29hgbotCheckin
2019-08-22 14:29hgbotNote Added: 0114127
2019-08-22 14:29hgbotStatusscheduled => resolved
2019-08-22 14:29hgbotResolutionopen => fixed
2019-08-22 14:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/63a0a24cf4ba1907b12b00765422c4b5c4a4b4fc [^]
2019-08-22 14:29SandrahuguetReview Assigned To => Sandrahuguet
2019-08-22 14:29SandrahuguetNote Added: 0114128
2019-08-22 14:29SandrahuguetStatusresolved => closed
2019-08-22 14:29SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-25 06:50hudsonbotCheckin
2019-08-25 06:50hudsonbotNote Added: 0114260

Notes
(0113631)
collazoandy4   
2019-07-24 19:41   
Test Plan
  Go to Financial Account and select Caja record
    In Account Configuration tab fill out the Cleared Payment Account field for both General Ledger records
  Create a new Sales Invoice for Alimentos y Supermercados, S.A BP, Total amount: 100, Payment Method: Al contado
    Complete and Pay the invoice
  Create a new Purchase for Bebidas Alegres, S.L. BP, Total amount: 100, Payment Method: Al contado
    Complete and Pay the invoice
  Go to Financial Account and select Caja record
    Create a new reconciliation for the previous transactions created by the invoice
    Post the reconciliation and check the process ends without error
(0114127)
hgbot   
2019-08-22 14:29   
Repository: erp/devel/pi
Changeset: 63a0a24cf4ba1907b12b00765422c4b5c4a4b4fc
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Jul 24 11:34:27 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/63a0a24cf4ba1907b12b00765422c4b5c4a4b4fc [^]

Fixed issue 41245: DocFINReconciliation.createFact is not using bind-params

Added missing bind-params

---
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
---
(0114128)
Sandrahuguet   
2019-08-22 14:29   
code review + testing ok
(0114260)
hudsonbot   
2019-08-25 06:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2915449dde15 [^]
Maturity status: Test