Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041244Openbravo ERP09. Financial managementpublic2019-07-02 16:262019-08-25 06:50
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041244: DocFINPayment.createFact is not using bind-params
DescriptionSeveral HQL in this method are not using bind-params.

When fixing please apply new HQL-style to all HQL in this file.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041435 closed collazoandy4 Apply HQL style guide to DocFINPayment 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 16:26shuehnerNew Issue
2019-07-02 16:26shuehnerAssigned To => Triage Finance
2019-07-02 16:26shuehnerModules => Core
2019-07-02 16:26shuehnerTriggers an Emergency Pack => No
2019-07-02 16:26shuehnerRelationship addedblocks 0038136
2019-07-04 12:16shuehnerTarget Version => 3.0PR19Q4
2019-07-23 16:16collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-23 16:16collazoandy4Statusnew => scheduled
2019-07-24 16:19collazoandy4Note Added: 0113621
2019-08-22 12:57SandrahuguetRelationship addedrelated to 0041435
2019-08-22 13:31hgbotCheckin
2019-08-22 13:31hgbotNote Added: 0114123
2019-08-22 13:31hgbotStatusscheduled => resolved
2019-08-22 13:31hgbotResolutionopen => fixed
2019-08-22 13:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b7f39107115cdfced0808271c0f3af598a600cfb [^]
2019-08-22 13:32SandrahuguetReview Assigned To => Sandrahuguet
2019-08-22 13:32SandrahuguetNote Added: 0114124
2019-08-22 13:32SandrahuguetStatusresolved => closed
2019-08-22 13:32SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-25 06:50hudsonbotCheckin
2019-08-25 06:50hudsonbotNote Added: 0114258

Notes
(0113621)
collazoandy4   
2019-07-24 16:19   
Test Plan
  Go to Financial Account window and select Cuenta de Banco record
    Select Transferencia record in Payment Method tab
      Fill out the Upon Receipt Use and Upon Reconciliation Use fields
  Create a new Sales Invoice for Alimentos y Supermercados, S.A
    Complete the invoice and Add a Payment
  Go to the Payment created and post it, check the process ends without errors
(0114123)
hgbot   
2019-08-22 13:31   
Repository: erp/devel/pi
Changeset: b7f39107115cdfced0808271c0f3af598a600cfb
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Jul 24 00:50:29 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/b7f39107115cdfced0808271c0f3af598a600cfb [^]

Fixes issue 41244: DocFINPayment.createFact is not using bind-params

Added missing bind-params

---
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
---
(0114124)
Sandrahuguet   
2019-08-22 13:32   
code review + testing ok
(0114258)
hudsonbot   
2019-08-25 06:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2915449dde15 [^]
Maturity status: Test