Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041242Openbravo ERP09. Financial managementpublic2019-07-02 16:232019-08-22 14:45
Reportershuehner 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4Fixed in Version3.0PR19Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041242: DocFINBankStatement.createFact is not using bind-params
DescriptionThe following code is not using bind-params:

      whereClause.append(
          " where astdt.acctschemaTable.accountingSchema.id = '" + as.m_C_AcctSchema_ID + "'");
      whereClause.append(" and astdt.acctschemaTable.table.id = '" + AD_Table_ID + "'");
      whereClause.append(" and astdt.documentCategory = '" + DocumentType + "'");

and

        whereClause2.append(" as ast ");
        whereClause2.append(" where ast.accountingSchema.id = '" + as.m_C_AcctSchema_ID + "'");
        whereClause2.append(" and ast.table.id = '" + AD_Table_ID + "'");

When fixing please apply new HQL style to all HQL in the file.

Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041419 closed collazoandy4 Apply HQL style guide to DocFINBankStatement 
blocks design defect 0038136 acknowledged Triage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-07-02 16:23shuehnerNew Issue
2019-07-02 16:23shuehnerAssigned To => Triage Finance
2019-07-02 16:23shuehnerModules => Core
2019-07-02 16:23shuehnerTriggers an Emergency Pack => No
2019-07-02 16:23shuehnerRelationship addedblocks 0038136
2019-07-04 12:15shuehnerTarget Version => 3.0PR19Q4
2019-07-22 17:57collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-22 17:58collazoandy4Statusnew => scheduled
2019-07-23 00:00collazoandy4Note Added: 0113583
2019-08-13 09:46SandrahuguetRelationship addedrelated to 0041419
2019-08-13 10:02hgbotCheckin
2019-08-13 10:02hgbotNote Added: 0113959
2019-08-13 10:02hgbotStatusscheduled => resolved
2019-08-13 10:02hgbotResolutionopen => fixed
2019-08-13 10:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/057aaf20b2931ef5c05ce63bc1b1144031dbacda [^]
2019-08-13 10:21SandrahuguetReview Assigned To => Sandrahuguet
2019-08-13 10:21SandrahuguetNote Added: 0113960
2019-08-13 10:21SandrahuguetStatusresolved => closed
2019-08-13 10:21SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114221

Notes
(0113583)
collazoandy4   
2019-07-23 00:00   
Test Plan
  Go to Financial Account and select Cuenta de Banco record
    In Account Configuration tab check Enable Bank Statement and fillout all the fields with valid values
    Go to Imported Bank Statement tab and create a new record, process and post it
    Check the process ends without error
(0113959)
hgbot   
2019-08-13 10:02   
Repository: erp/devel/pi
Changeset: 057aaf20b2931ef5c05ce63bc1b1144031dbacda
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Jul 22 17:04:40 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/057aaf20b2931ef5c05ce63bc1b1144031dbacda [^]

Fixes issue 41242: DocFINBankStatement.createFact is not using bind-params

Added missing bind-params

---
M src/org/openbravo/erpCommon/ad_forms/DocFINBankStatement.java
---
(0113960)
Sandrahuguet   
2019-08-13 10:21   
code review + testing ok
(0114221)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test