Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041240Openbravo ERP09. Financial managementpublic2019-07-02 16:202019-08-22 14:45
shuehner 
collazoandy4 
normalminorhave not tried
closedfixed 
5
 
3.0PR19Q43.0PR19Q4 
Sandrahuguet
Core
No
0041240: AcctServer.{getAccountDBpartner, disableDocumentConfirmation} are not using bind-params
HQL in those functions is not using bind-params.

When fixing please apply new HQL-style to all 7 HQL in the file.
-
No tags attached.
related to defect 0041418 closed collazoandy4 Apply HQL style guide to AcctServer 
blocks design defect 0038136 acknowledged platform Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Issue History
2019-07-02 16:20shuehnerNew Issue
2019-07-02 16:20shuehnerAssigned To => Triage Finance
2019-07-02 16:20shuehnerModules => Core
2019-07-02 16:20shuehnerTriggers an Emergency Pack => No
2019-07-02 16:20shuehnerRelationship addedblocks 0038136
2019-07-04 12:15shuehnerTarget Version => 3.0PR19Q4
2019-07-22 16:07collazoandy4Assigned ToTriage Finance => collazoandy4
2019-07-22 16:07collazoandy4Statusnew => scheduled
2019-07-23 00:00collazoandy4Note Added: 0113581
2019-08-19 10:19SandrahuguetRelationship addedrelated to 0041418
2019-08-19 11:27hgbotCheckin
2019-08-19 11:27hgbotNote Added: 0114074
2019-08-19 11:27hgbotStatusscheduled => resolved
2019-08-19 11:27hgbotResolutionopen => fixed
2019-08-19 11:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2a242dee2daa42b5e2bba3c4cb1ddaa3edac48b3 [^]
2019-08-19 11:27hgbotCheckin
2019-08-19 11:27hgbotNote Added: 0114076
2019-08-19 11:28SandrahuguetReview Assigned To => Sandrahuguet
2019-08-19 11:28SandrahuguetNote Added: 0114077
2019-08-19 11:28SandrahuguetStatusresolved => closed
2019-08-19 11:28SandrahuguetFixed in Version => 3.0PR19Q4
2019-08-19 12:58hgbotCheckin
2019-08-19 12:58hgbotNote Added: 0114085
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114229
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114231
2019-08-22 14:45hudsonbotCheckin
2019-08-22 14:45hudsonbotNote Added: 0114232

Notes
(0113581)
collazoandy4   
2019-07-23 00:00   
Test Plan
  Complete and Post a new Sales Invoice
(0114074)
hgbot   
2019-08-19 11:27   
Repository: erp/devel/pi
Changeset: 2a242dee2daa42b5e2bba3c4cb1ddaa3edac48b3
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Jul 22 16:20:25 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/2a242dee2daa42b5e2bba3c4cb1ddaa3edac48b3 [^]

Fixes issue 41240: AcctServer.{getAccountDBpartner, disableDocumentConfirmation}
are not using bind-params

Added missing bind-params

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0114076)
hgbot   
2019-08-19 11:27   
Repository: erp/devel/pi
Changeset: 1e378565c87fefba4ff07d8cb60de7dca339aae3
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 19 11:20:42 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1e378565c87fefba4ff07d8cb60de7dca339aae3 [^]

related to issue 41240 fix correct bind parameter

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0114077)
Sandrahuguet   
2019-08-19 11:28   
code review + testing ok
(0114085)
hgbot   
2019-08-19 12:58   
Repository: erp/devel/pi
Changeset: b2063b37126e32cb5eb8dcb1e05bb052e02d677b
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Aug 19 12:57:44 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b2063b37126e32cb5eb8dcb1e05bb052e02d677b [^]

related to issue 41240 check if documentType is null when adding bindparam

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0114229)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114231)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test
(0114232)
hudsonbot   
2019-08-22 14:45   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ad3efd3bd07c [^]
Maturity status: Test